Page MenuHomePhabricator

the movepage special page does not deal with image pages properly
Closed, ResolvedPublic

Description

Author: jsherman

Description:
If the name of a page in the image namespace is manually given as an argument to
the Movepage special page (ie. Special:Movepage/Image:someimage.jpg), the page
handles issues badly. If you try to move the image page to another page in the
image namespace that does not exist (essentially renaming it), it tells you:

Destination title is of a special type; cannot move pages into that namespace.

It would probably be better and more accurate to give an error if a page in the
Image namespace is loaded as the argument to Movepage when it is loaded, saying
that you cannot move image pages, instead of giving a semi-irrelevant error
after one tries to move the image.

Even worse, if you try to move the image to a new title in the main namespace,
it gives you the same error, saying that the destination title is of a special
type, when in reality, it isn't.


Version: 1.6.x
Severity: minor
OS: Mac OS X 10.0
Platform: Macintosh

Details

Reference
bz6216

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:16 PM
bzimport set Reference to bz6216.
bzimport added a subscriber: Unknown Object (MLST).

jsherman wrote:

A patch for Title.php;

loads a message (MediaWiki:Baddestination) when the destination name of the
page is in a bad namespace (like the image namespace) and the regular message
(MediaWiki:Immobile_namespace) when the source page is in a bad namespace (also
includes image namespace). The MediaWiki message pages therefore need to be
changed; I made Baddestination:

Destination title is of a special type; cannot move pages into that namespace.

(originally from the old message for both cases)

and the Immobile_namespace message:

The page to be moved is of a special type; cannot move pages from that
namespace.

I assume that the installer script that creates and populates the database
originally would need to be updated to reflect these changes in system
messages.

Attached:

(In reply to comment #2)

Duplicate of #709?

No.

rotemliss wrote:

Now mentioning the source page in "immobile_namespace". I don't think we need
another message for that.