Page MenuHomePhabricator

Bug fixes for sr: variants
Closed, ResolvedPublic

Description

During the past couple of weeks, Serbian developers, especially Robert, have
been doing hard on fixing bugs that were brought by installing variants system a
few months ago with bug #3993. Following this message, Robert will upload
patches against HEAD for files that were changed. It would be nice if developers
evaluated the patch as soon as possible and gave us their opinions, so we could
fine-tune the code if needed.


Version: 1.7.x
Severity: normal
URL: http://www.slavopedija.org/dev-vikimedija-sr/

Details

Reference
bz6300

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:21 PM
bzimport set Reference to bz6300.
bzimport added a subscriber: Unknown Object (MLST).

rainman wrote:

Patch agains multiple minor bugs related to Serbian variants

Contains a patch for:

  • Parser.php - we check if template name exist in some of the variants. This is

almost indentical code to that for checking variants of links (which is already
present in Parser.php), but now applied for templates. It is a minor patch.

  • LanguageConverter.php - we fix a bug when -{ }- tags are within HTML code

(for instance in paragraph names), we prevent the conversion of HTML code
(which is never a good idea and thus should apply to all multiple-variant
languages).

  • LanguageSr.php - we redefine some of the default behavior of the

LanguageConverter. These are specific to our local Serbian wiki. These include:
for the default variant don't convert the link names, don't convert the titles
of images, enable conversion in external links and disable conversion for talk
pages.

Attached:

Committed in r14791 and synchronized afterward during the night/morning UTC.
Marking this fixed