Page MenuHomePhabricator

CSS IDs in MonoBook.php and commonPrint.css don't match
Closed, ResolvedPublic

Description

Author: z9z8z-wps

Description:
Earlier the elements of the list in the page footer in skins/MonoBook.php were tagged with CSS IDs like "f-disclaimer". Sometime the "f-" got lost.
Now hiding of links in skins/common/commonPrint.css by refering to the no longer existing "f-" IDs does not work.


Version: 1.9.x
Severity: trivial

Details

Reference
bz6503

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:22 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz6503.
bzimport added a subscriber: Unknown Object (MLST).

z9z8z-wps wrote:

It appears it happened in the change to revision 12212 of skins/MonoBook.php

Now changing line 260 from

?> <li id="<?=$aLink?>"><?= $this->html($aLink) ?></li>

to

?> <li id="f-<?=$aLink?>"><?= $this->html($aLink) ?></li>

should fix this.

z9z8z-wps wrote:

Meanwhile it's changing

?> <li id="<?php echo$aLink?>"><?php $this->html($aLink) ?></li>

to

?> <li id="f-<?php echo$aLink?>"><?php $this->html($aLink) ?></li>

Li-sung wrote:

Change id in commonPrint.css

This patch should change id in commonPrint.css, so that it match with right id
in use

Attached:

z9z8z-wps wrote:

I would have patched that other single line since that does fix what most likely was forgotten in the above mentioned change to r12212 *and*
it would keep the "f-" in all "f"ooter IDs making the style sheet easier to read.
However the other way should work too.

Li-sung wrote:

Patch adding f- so id match with commonPrint.css

Choose only one patch

Attached:

ayg wrote:

I picked the patch from comment #3 because a) people may have customized CSS/JS
based on the current id and b) the equivalent links might not actually be in a
footer in other skins.

z9z8z-wps wrote:

Monobook IDs won't appear in Cologne Blue ... and if it takes few over six months to fix two forgotten letters the thought to consider the
buggy names as established has something.