Page MenuHomePhabricator

Problem with namespace specific search
Closed, ResolvedPublic

Description

Author: Eneas

Description:
At the attached link you can see an inputbox which should only search trough the
help namespace. But when you search specific terms you get articles of the same
name.

Examples: Vorlagen, Programmierung,...


Version: unspecified
Severity: normal
URL: http://de.wikipedia.org/wiki/Benutzer:Eneas/Bug-Inputbox

Details

Reference
bz7318

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
ResolvedNone

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:22 PM
bzimport set Reference to bz7318.

If the searchterm is an exact match of an article in NS0 then this article will
be shown. It seams, that the inputbox button has the function of the "Go" button.

If the search term isn't in NS0 then the search works as requested. Example:
"Diskussionsseiten"

Possible solutions:

  1. Change the inputbox button to the function of the "Search" button Disadvantage: If the search term exists in the requested namespace one more

click is required

  1. Extend the search term with the requested namespace Disadvantage: maybe not possible with 2 or more requested namespaces

Eneas wrote:

Due to usability reasons I would suggest to take the frist solution. Users
usually expect a list of search results because they are used to it because of
internet search engines.

Eneas wrote:

*** Bug 7574 has been marked as a duplicate of this bug. ***

Eneas wrote:

Replaced "searchx" with "fulltextsearch" in Inputpbox.php

I dind't test the patch beacause I don't know how to. Can somebody help me?

attachment inputbox-patch.php ignored as obsolete

robchur wrote:

Comment on attachment 2911
Replaced "searchx" with "fulltextsearch" in Inputpbox.php

Please submit patches (SVN unified diff files) against the changed file, rather
than the entire file itself.

To test the patch is quite simple; does this change to the file fix the
reported problem or introduce the requested functionality, and does it do it
without breaking anything else?

Eneas wrote:

Make fulltextsearch with inputbox available

Here is the requested diff-file. The patch will not break anything. It should
also fix the reported problem. (I still didn't test it)

Attached:

Eneas wrote:

The patch works correctly. I tested it today. What are the next steps?

leon wrote:

Applied in SVN trunk, r19700.

leon wrote:

Man, I always forget to credit the authors in the commit messages for their
patches when they're from Bugzilla :-(
I'm sorry.