Page MenuHomePhabricator

update "Pages transcluded onto ... this page:" on edit preview
Closed, ResolvedPublic

Assigned To
None
Authored By
bzimport
Nov 14 2006, 1:31 PM
Referenced Files
F3461: patch
Nov 21 2014, 9:30 PM
F3460: patch
Nov 21 2014, 9:29 PM

Description

Author: chemicalbit

Description:
When you edit a page, and you add a template ( or other transclusion ) and you
press "show preview" , you can see a preview that have aslo the (new added)
template.

But the template list just below edit textarea ("Pages transcluded onto the
current version of this page:" in english interface) is not updated, until you
save the page.

(the precise statement "the current version" is in english interface. Other
interface, italian one for example, have not. So it's less clear what that list
_exactly_ is )

I suggest to improve to show the list updated when the user press "show preview".
It is: the list should be pertinent to the version shown in the preview.

This may be usefull :

  1. to check the exactness of the template name in the page (if one mispelled a

template name, it will be shown in red colour in the list), as in complex page
one may not relize it

  1. to find out if a template do not exist yet, or if have been deleted
  1. to find out which template is used in a page "I want to use it in the page

I'm writing too"

4)to click on the link and open in another windows / tab the template page to
look at instruction, for complex syntax templates

and maybe more


Version: 1.9.x
Severity: enhancement

Details

Reference
bz7918

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:29 PM
bzimport set Reference to bz7918.
bzimport added a subscriber: Unknown Object (MLST).

fyrenmoo wrote:

implements the request

Seems to work fine on my test wiki.

Attached:

ayg wrote:

Patch applied in r17738.

(In reply to comment #2)

Patch applied in r17738.

[[Special:Version]]: MediaWiki: 1.9alpha (r17763)

Sorry, but don't work for me, neither on dewiki nor in dews.

The new message is in [[Special:Allmessages]] but after clicking on "Preview"
there is no list. At the HTML sourcecode I can see

<div class="templatesUsed">

</div>

only... empty. zero. nada :-(

ayg wrote:

It works correctly for me on enwiki. Does it fail for anyone else? Are you
using any custom scripts? I didn't see the edit summary preview change until I
stopped using a live preview script.

(I did notice an unintended feature: when previewing a section, it will now only
show templates used in that *section*. This seems like a good thing to me,
overall, but this should also happen when editing and not previewing a section,
and the message should be clarified accordingly. Also, it doesn't make a lot of
sense for "show changes" to still use the template list for the current version
of the page. I don't have time right now, but I'll fix those tomorrow night if
no one else does before me.)

(In reply to comment #4)

It works correctly for me on enwiki. Does it fail for anyone else? Are you
using any custom scripts? I didn't see the edit summary preview change until I
stopped using a live preview script.

No custom scipt at de-wikisource where the problem exists too. But I have found
that if the preference "Show preview before edit box" is OFF the preview of used
templates fails.

If the option is ON it works well.

And please check whu(In reply to comment #5)

If the option is ON it works well.

And [[MediaWiki:templatesused]] is still used instead of
[[MediaWiki:templatesusedpreview]]

fyrenmoo wrote:

fixes and section handling as suggested

This patch fixes the problem with the preview being after the edit box (my
problem, I depended on the preview being parsed before displaying the used
templates) and the message problem (Simetrical's problem, he broke it when he
moved formatTemplates into Linker.php).

It also checks to see if you're editing a section to display the appropriate
message and only the templates for that section.

Attached:

ayg wrote:

Patch applied with trivial modifications in r17800. If there are any further
problems, please open a new bug.