Page MenuHomePhabricator

New page automatic summaries override prompt for blank summary
Closed, ResolvedPublic

Description

Tested on new page summary, new redirect summary and blanking page summary. I
was unable to trigger the "content rewritten with" summary, so I guess this one
does not override the blank summary prompt.

I'd suggest either forcing of prompt in every occasion or another checkbox
"Prompt for blank summary even when automatic summary available" in
Special:Preferences.

Thanks


Version: unspecified
Severity: normal

Details

Reference
bz8065

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:31 PM
bzimport set Reference to bz8065.
bzimport added a subscriber: Unknown Object (MLST).

rotemliss wrote:

New pages and redirects (new and existing) don't require a manual summary, by
purpose. However, a blanking summary and replacing summary (which is created by
removing more than 90% from a page; the new page should be below 500 characters)
should require it. Checking them.

Seems to be a regression from r17804.

rotemliss wrote:

I can't reproduce this bug on my MediaWiki installation (latest trunk, English,
preference is on). Probably worksframe. Where did you check it? If it's a local
installation, try to do "svn update".

(In reply to comment #1)

New pages and redirects (new and existing) don't require a manual summary, by
purpose.

I can understand this, that's why I proposed the checkbox in preferences as the
alternative to force prompt.

On the other hand I know, there are people who like to fill it but sometimes
they just forget and that's why they have the prompt set on.

Prompt has also one nice side-effect: while creating new page you can
accidentaly press Submit instead of Preview and prompt blocks it from submitting
of half-done version.

(In reply to comment #3)

I can't reproduce this bug on my MediaWiki installation (latest trunk, English,
preference is on). Probably worksframe. Where did you check it? If it's a local
installation, try to do "svn update".

Tested on cs.wikipedia -
http://cs.wikipedia.org/w/index.php?title=Wikipedista:Danny_B./test_shrnut%C3%AD&curid=150135&action=history

robchur wrote:

When the preference is on, automatic summaries should be avoided wherever
possible in favour of screaming at the user to provide one.

Looking at the code, this is no longer the case.

It is.

I do have "Prompt me when entering a blank edit summary" checked and it does not prompt when saving new page.

http://test.wikipedia.org/w/index.php?title=Autosummary&action=history

Gah, thought this was about section summaries. Fixed in r45843.

(In reply to comment #8)

Gah, thought this was about section summaries. Fixed in r45843.

Redirects left the same though.

Just confirming, I see new pages being added without edit summaries, even though I have "Prompt me when entering a blank edit summary" checked, on Wikipedia and Wikiquote now (1.21wmf6 (9e7e0d1)).

Mark / Danny: Please file new bug reports instead of reopening issues that were fixed three years ago. The problem likely is something different in the codebase, even if it has the same outcome.

I didn't attempt to reopen (or add a new bug) because the commentary above for this bug did not make it (completely) clear that this scenario was addressed. I will start a new bug.

(In reply to comment #12)

Mark / Danny: Please file new bug reports instead of reopening issues that
were
fixed three years ago. The problem likely is something different in the
codebase, even if it has the same outcome.

This is still the same *issue*. And *this issue* has not been solved, not even three years ago (I just simply forgot about this bug because made myself a gadget to fix that). Bugs are about issues not about particular line in code. If the issue is triggered by several places in code, then still one bug is supposed to be opened, not a single bug per any relevant place which triggers the issue.