Page MenuHomePhabricator
Create Task
Maniphest T10449

Templates in CSS and JS pages should not be expanded
Closed, ResolvedPublic
Actions

Description

Author: inbox2

Description:
Templates in [[MediaWiki:Common.js]] are not only expanded when viewing the
stylesheet at http://en.wikipedia.org/wiki/MedaiWiki:Common.js, but also in
the generated stylesheet code
http://en.wikipedia.org/w/index.php?title=-&action=raw&smaxage=0&gen=js. This
behaviour is inconsistent with how templates are expanded in personal
stylesheets. Not expanding templates in the generated stylesheet would allow
documentation to be placed in [[MediaWiki:Common.js]] without significantly
increasing the size of the generated stylesheet.

Version: 1.11.x
Severity: minor
URL: http://en.wikipedia.org/wiki/MediaWiki:Common.js

Details

Reference
bz8449

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 9:30 PM
• bzimport added a project: MediaWiki-ContentHandler.
• bzimport set Reference to bz8449.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Jan 1 2007, 1:45 AM
• bzimport added a comment.Jul 15 2007, 1:51 AM

ayg wrote:

Display in the page itself has been fixed with r23657 et al. (see bug 10432 and related). I can confirm that action=raw still expands templates for CSS/JS pages. Workaround for now: don't use templates in them. ;)

Nemo_bis added a comment.Nov 3 2012, 8:56 AM

Is this fixed by ContentHandler?

Jackmcbarn added a comment.Sep 20 2014, 6:38 PM

This bug also applies to user JS and CSS pages; description updated.

(In reply to Nemo from comment #2)

Is this fixed by ContentHandler?

No.

Jackmcbarn added a comment.Sep 20 2014, 6:38 PM
  • Bug 8761 has been marked as a duplicate of this bug. ***
He7d3r added a comment.Sep 20 2014, 6:53 PM

This is fixed, since
https://ca.wikipedia.org/w/index.php?title=MediaWiki:Common.js&action=raw&ctype=text/javascript
keeps every ocurrence of "{{referències}}" intact, therefore not increasing the size of the JS page.

Jackmcbarn added a comment.Sep 20 2014, 7:10 PM

It's not actually completely fixed. Things like subst still present a problem, and pages still end up in erroneous categories.

jayvdb subscribed.Aug 19 2015, 1:59 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 1:59 AM
Bawolff closed this task as Resolved.Sep 9 2016, 4:29 AM
Bawolff subscribed.

http://en.wikipedia.org/w/index.php?title=-&action=raw&smaxage=0&gen=js.

We no longer use that for site javascript and RL doesn't have same behaviour. I'm closing this. For any parsing to add stuff to links tables, see T18683. For PST (subst:) see T61616:

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL