Page MenuHomePhabricator

Suppress paging links and related messages where there are no rows to list for query pages
Closed, ResolvedPublic

Description

Please disable the message with number of results and navigation bars if special
page is empty:

Showing below up to 0 results starting with #1.
View (previous 50) (next 50) (20 | 50 | 100 | 250 | 500).

View (previous 50) (next 50) (20 | 50 | 100 | 250 | 500).

This looks a bit silly ;-)

Instead introduce a new message like "This list is empty"


Version: unspecified
Severity: enhancement

Details

Reference
bz8919

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:36 PM
bzimport set Reference to bz8919.
bzimport added a subscriber: Unknown Object (MLST).

suisui wrote:

a patch for it. just putting a line when $num == 0

I've maked a patch for it
with wfMsg('table_pager_empty')

attachment QueryPage.patch ignored as obsolete

robchur wrote:

(In reply to comment #1)

with wfMsg('table_pager_empty')

Try to avoid echoing raw messages as HTML without any sort of escaping
whatsoever. Consider wfMsgHtml() for this case.

suisui wrote:

fixed patch with MsgHTML

thankx I've fixed the patch with MsgHTML.

Attached:

Based on Sui Mins patch fixed in r20019