$_SERVER['REQUEST_URI'] undefined on IIS 5.0, Patch included
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Feb 15 2007, 10:59 AM

Description

Author: daniel.schoemer

Description:
Running Mediawiki 1.9.2 on Windows 2000 Server with Internet Information
Services 5.0.

On a page history, the following PHP warning gets displayed:

Notice: Undefined index: REQUEST_URI in ...\includes\Wiki.php on line 427

The following patch eleminates the warning for me:

+++ includes/Wiki.php 2007-02-15 10:43:47 +0000
@@ -422,7 +422,8 @@

        }
        break;
case 'history':

getInternalURL( 'action=history' ) ) {

+ $request_uri =
array_key_exists('REQUEST_URI', $_SERVER) ? $_SERVER['REQUEST_URI'] :
$_SERVER['ORIG_PATH_INFO'];
+ if( $request_uri == $title-

getInternalURL( 'action=history' ) ) {

$output->setSquidMaxage( $this-

getVal( 'SquidMaxage' ) );

}
$history = new PageHistory( $article );

Version: 1.9.x
Severity: trivial
OS: Windows 2000
Platform: PC

• bzimport raised the priority of this task from to Low.Nov 21 2014, 9:33 PM

• bzimport set Reference to bz8992.

• bzimport added a subscriber: Unknown Object (MLST).

daniel.schoemer wrote:

Patch for bug #8992

Attached patch

Attached:

a.patch584 BDownload

Correct fix is to use $wgRequest functions as done elsewhere for bug 3000; this
one apparently missed the boat. :)

Fixed on trunk in r19956, REL1_9 in r19957

ammatsun wrote:

Additional patch for bug #8992

Resolves similar issue with REQUEST_URI in includes/Article.php.

Attached:

ArticlePatch544 BDownload

Done in r42400.

	F3623: ArticlePatch
	Nov 21 2014, 9:33 PM

	F3622: a.patch
	Nov 21 2014, 9:33 PM