Page MenuHomePhabricator
Create Task
Maniphest T11166

Recent changes rebuild script doesn't restore rc_bot value
Closed, ResolvedPublic
Actions

Description

Author: gunter.schmidt

Description:
The script rebuildrecentchanges.php has a litte error. It does not check, if the user is a bot. Thus all
changes by bots appear in the recent change list.

It should check if the user is a bot and set the bot-flag to 1.

Version: 1.11.x
Severity: normal

Details

Reference
bz9166

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:37 PM
• bzimport added projects: MediaWiki-General, good first task.
• bzimport set Reference to bz9166.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Mar 4 2007, 8:17 PM
• bzimport added a comment.Mar 6 2007, 11:08 PM

suisui wrote:

proposed patch for svn r20183

I made a patch for this trunk/ r20183

Attached:

rebuildrecentchanges.patch454 BDownload

• bzimport added a comment.Mar 6 2007, 11:22 PM

robchur wrote:

Comments for Database::set() indicate it is deprecated. Use Database::update()
instead.

• bzimport added a comment.Mar 6 2007, 11:31 PM

suisui wrote:

Database::update doesnt hang
ug_user=rc_user part cause Database::update uses makeList() to expand
so it is treated as ug_user = 'rc_user'

• bzimport added a comment.Mar 20 2007, 5:47 AM

end_invites wrote:

shouldn't this patch be reviewed?

aaron added a comment.Jun 3 2007, 10:38 PM

Done in r22348.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL