Page MenuHomePhabricator
Create Task
Maniphest T12266

rebuildLanguage.php bug with newlines
Closed, ResolvedPublic
Actions

Description

Update to rebuildLanguage system

I experienced this bug a few times today, when I edited a MessagesXX.php file in Windows environment, then used rebuildLanguage.php and after that, the final messages file contained both Linux (\n) and Windows (\r\n) line endings in it. Because of this, svn could not create a patch file.

I figured that I can create a very tiny PHP file for myself, that would replace all \r\n combinations with \n (that is to convert all line endings to Linux type). This way, the above problem was sovled.

I believed there would be no harm in updating rebuildLangauges system in a way that it would perform that operation prior to writing the messages to the file, so I created a patch for that.

Version: unspecified
Severity: enhancement

attachment a.diff ignored as obsolete

Details

Reference
bz10266

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedNoneT14170 Inconsistant newlines in MessagesEn.php
 ResolvedNoneT12266 rebuildLanguage.php bug with newlines

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:51 PM
• bzimport added a project: MediaWiki-General.
• bzimport set Reference to bz10266.
• bzimport added a subscriber: Unknown Object (MLST).
Huji created this task.Jun 15 2007, 12:05 AM
Huji added a comment.Jun 15 2007, 12:07 AM

Created attachment 3772
Update to rebuildLanguage system

fixed a typo

attachment a.diff ignored as obsolete

Huji added a comment.Jun 15 2007, 7:15 AM

Created attachment 3774
Fixed the issues in previous patch

Fixed the issues in previous patch. It still needs being reviewed.

Attached:

diff.diff521 BDownload

• brion added a comment.Jun 15 2007, 6:09 PM

The sensible thing is probably to:
a) Normalize \r\n to \n on input
b) Normalize \n to the local newline sequence on output

You could use the PHP_EOL constant (available since PHP 5.0.2), or try detecting it from the source file for consistency.

Huji added a comment.Jun 16 2007, 8:25 AM

Well I didn't understand what you are concerned about in the (b) section. Could you please give an example?

Raymond added a comment.Jul 30 2007, 4:24 PM

Fixed with r24423 by Rotem.

Huji added a comment.Jul 30 2007, 4:49 PM

Raimond,

I'm not sure if r24423 is what I actually meant here. I think what Brion said is a better idea: To change all \r\n to \n. Then to change them back to the local newline sequence (this second part is not necessary). The benefit is, if the file contains a mixture of \n newlines and \r\n newlines, they will be all made similar.

Raymond added a comment.Jul 30 2007, 4:55 PM

Hmmm maybe...

In the past I got SVN commit errors after running rebuildLanguage.php due to a mixture of newlines. With r24423 SVN doesn't whine anymore :)

Ok, let's check again :)

Huji added a comment.Jul 30 2007, 5:03 PM

Good idea. I may test it later on as well, when I manage to translate some of the new messages for MessagesFa.

Raymond added a comment.Feb 28 2009, 7:16 PM

seems fixed a while ago.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL