Page MenuHomePhabricator

Delete link in file history for non-admins
Closed, ResolvedPublic

Description

The delete links for entries in file histories is shown for all logged-in users. The links should only be shown to admins (since other users only get a permission error if they follow the link).


Version: unspecified
Severity: enhancement

Details

Reference
bz10741

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:48 PM
bzimport set Reference to bz10741.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

There isn't a link, at least not in current trunk, but there is some plain text where the link would be - "(del)". I guess this is being done to keep the other columns in line, although whether it *should* is another matter.

It might make more sense to use a little table here; the data semantics would allow it.