Page MenuHomePhabricator

redundant horizontal line appears in right-to-left Wikimedia sites with Vector skin in Firefox
Closed, ResolvedPublic

Description

I enabled the Beta, the new toolbar and the editing dialogs in Hebrew Wikipedia, Wikisource and Wikinews and in the Arabic Wikipedia. When i am editing a page and hover with the mouse cursor over buttons in the toolbar, a thin horizontal appears, that stretches from the button all the way to the right.

This doesn't happen on English WM sites and since it happens in Hebrew and Arabic, this may have something to do with the right-to-left support.

I am using Firefox 3.6 on Windows XP. This also doesn't happen in Google Chrome or Opera.


Version: unspecified
Severity: major

Details

Reference
bz23083

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:10 PM
bzimport set Reference to bz23083.

This was caused by us switching to using <a> tags instead of <img> tags on icons which used sprited images. The <a> tags inherited an underline effect on hover, which oddly was only visible in right-to-left mode. There were also accessibility concerns about the use of <a> tags for these images, specifically to do with the way screen readers collect and interact with links, so I've changed the sprited icons over to use <span> tags instead in r65556.