Page MenuHomePhabricator

Icons for stashed audio files are broken
Open, LowPublic

Description

Author: neilk

Description:
When we try to obtain the icon for an uploaded audio file, instead of fetching the standard audio icon, we instead do this exchange:

http://commons.prototype.wikimedia.org/w/api.php?action=query&format=json&prop=stashimageinfo&siisessionkey=chbquaktkhol08cdl6sq3x9nxqj11vj&siiurlwidth=120&siiprop=url

{"servedby":"commons.prototype.wikimedia.org","error":{"code":"siiinvalidsessiondata","info":"Bad path: path '\/srv\/org\/wikimedia\/prototype\/wikis\/commons\/images\/temp\/5\/51\/mid-chbquaktkhol08cdl6sq3x9nxqj11vj.ogx.jpg' doesn't exist"}}

In other words, the filename manipulation that is correct for a stashed JPG -- to get a thumbnail of that, generated in the temp space -- isn't correct for an OGG file, whose thumbnail will be based off an existing icon, already published.


Version: unspecified
Severity: minor

Details

Reference
bz25902

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 11:18 PM
bzimport added a project: UploadWizard.
bzimport set Reference to bz25902.
bzimport added a subscriber: Unknown Object (MLST).

neilk wrote:

*** Bug 25828 has been marked as a duplicate of this bug. ***

I took a look at this, but the callbacks and methods for setting the thumbnail are so confused that I can't reliably set the thumbnail without it getting overwritten at some point. I'm not fully sure why this all happens, but I'm also not sure this is a priority right now. I'm going to lower it, and come back to this one later.