Page MenuHomePhabricator

Users with full blocks are able to edit LQT thread subjects
Closed, ResolvedPublic

Description

Author: thor.malmjursson

Description:
Hi. It's been bought to my attention this evening that users who are under the effect of a full indefinite block are still able to edit LiquidThreads stuff.

I have no idea whether this is intentional, but my guess is no, it isn't.

I'll present proof below, taken from a recent change log via irc:

[19:18:15] <rc-pmtpa> [[Special:Log/block]] block * Diego Grez * blocked [[User:Aussieladlav 6]] with an expiry time of indefinite (account creation disabled): vandal

[19:18:55] <rc-pmtpa> [[Special:Log/liquidthreads]] subjectedit * Aussieladlav 6 * changed the subject of <a href="/wiki/Thread:Comments:Qur%27an-burning_pastor_jailed_after_mosque_protest_barred/Comments_from_feedback_form_-_%22With_so_much_at_stake_%26_everyt...%22">

Would someone please be kind enough to look into this, since if a user is blocked, the only thing they should be able to edit is their own talk page (unless we withdraw that right). Thanks :)


Version: unspecified
Severity: critical

Details

Reference
bz28685

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 21 2014, 11:24 PM
bzimport set Reference to bz28685.

I'm not able to reproduce locally nor on MediaWiki.org, attempting several methods. Have you seen this happen again?

I'll also note that the block and the edit in question occurred in the same minute, and so perhaps that's why the action got through this time.

Please let me know if this event occurs again.

I can reproduce on enwikinews. Note, its editing the subject of the thread, not the thread itself.

Sequence of events (from #en.wikinews on irc.wikimedia.org RC channel). I tried editing multiple subject headers, just to make sure:

[17:12] <rc-pmtpa> [[Special:Log/block]] block * Bawolff * blocked [[User:Bawolff]] with an expiry time of 4 minutes (autoblock disabled): testing something with lqt

[17:12] <rc-pmtpa> [[Special:Log/liquidthreads]] subjectedit * Bawolff * changed the subject of <a href="/wikinews/en/wiki/Thread:Comments:IMF_head_remains_in_New_York_prison;_charged_over_alleged_hotel_sex_attack/Comments_from_feedback_form_-_%22At_the_very_least_the_Strauss_...%22" title="Thread:Comments:IMF head remains in New York prison; charged over alleged hotel sex attack/Comments from feedback form - "At the very least the Strau

[17:12] <rc-pmtpa> [[Special:Log/liquidthreads]] subjectedit * Bawolff * changed the subject of <a href="/wikinews/en/wiki/Thread:Comments:IMF_head_to_appear_at_New_York_court_after_alleged_hotel_sex_attack/Comments_from_feedback_form_-_%22this_is_the_first_time_that_i_...%22" title="Thread:Comments:IMF head to appear at New York court after alleged hotel sex attack/Comments from feedback form - "this is the first time that i ..."">Threa

[17:13] <rc-pmtpa> [[Special:Log/liquidthreads]] subjectedit * Bawolff * changed the subject of <a href="/wikinews/en/wiki/Thread:Comments:IMF_head_remains_in_New_York_prison;_charged_over_alleged_hotel_sex_attack/Comments_from_feedback_form_-_%22Need_to_be_completed_with_rece...%22" title="Thread:Comments:IMF head remains in New York prison; charged over alleged hotel sex attack/Comments from feedback form - "Need to be completed with r

Relevant log entries at: https://secure.wikimedia.org/wikinews/en/w/index.php?title=Special%3ALog&type=liquidthreads&user=bawolff&page=&year=&month=-1&tagfilter=&hide_patrol_log=1&hide_review_log=1 and https://secure.wikimedia.org/wikinews/en/w/index.php?title=Special%3ALog&type=block&user=Bawolff&page=User%3ABawolff&year=&month=-1&tagfilter=

Thanks for reporting this, Brian.

I've fixed this bug in r88574, which I'll deploy in the coming days.

thor.malmjursson wrote:

Brian? Who's Brian? What am I, Chopped Liver??? :) Thanks for fixing Andrew!

(In reply to comment #4)

Brian? Who's Brian?

Brian Wolff (bawolff)

lol, to clarify BarkingFish (Thor) was the reporter, not I.