When doing multiple automatic edits I occasionally get unknown error 231 in between the database lock errors.
Version: unspecified
Severity: normal
Description
Description
Details
Details
- Reference
- bz29246
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T31068 MediaWiki bugs to be fixed for 1.18wmf1 deployment (tracking) | |||
| Resolved | Reedy | T31246 API errors occasionally with unknown error 231 |
Event Timeline
Comment Actions
This is caused by the following sequence of events:
- Article::doEdit() fails, and returns a Status object with failure info
- EditPage::internalAttemptSave() checks for $status->isOK(), and returns AS_END if $status signifies an error. The Status object is discarded
- API doesn't handle AS_END, falls through to returning an unknown error. There's a comment here about needing to propagate the Status object
I guess the best way to fix this would be to refactor internalAttemptSave() to return a Status object instead of one of 30+ error codes.
Comment Actions
(In reply to comment #1)
I guess the best way to fix this would be to refactor internalAttemptSave() to
return a Status object instead of one of 30+ error codes.
Please! For back-compat, you can set the error code in $status->value on failure.
Comment Actions
(In reply to comment #2)
(In reply to comment #1)
I guess the best way to fix this would be to refactor internalAttemptSave() to
return a Status object instead of one of 30+ error codes.Please! For back-compat, you can set the error code in $status->value on
failure.
Thanks for that tip. I took it a little bit further and just made all flow decisions based on $status->value, because EditPage is such a mess.
Fixed in r95562.