Page MenuHomePhabricator

Installer should sanity check pre-existing tables
Open, MediumPublicFeature

Description

Author: ezyang

Description:
Consider the following database, which we would like to install MediaWiki onto:

mysql> show tables;
+----------------------------------------------+

Tables_in_wizard_test_mediawiki_install_head

+----------------------------------------------+

user

+----------------------------------------------+
1 row in set (0.00 sec)

There's a single user table here, ostensibly left over from a failed install. OK, that's fine. How does the installer cope? It claims "config-install-tables-exist", and then cheerfully attempts to access 'interwiki' table, which doesn't exist.

Ironically, the user table is unconditionally created.

Ideally, DatabaseInstaller->createTables should sanity check the existing tables and error out with something more reasonable if they don't match up with the schema, or complain that you should rather be using the ugprader.

You can treat this as a feature request. Probably.


Version: 1.17.x
Severity: enhancement

Details

Reference
bz29590

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:34 PM
bzimport set Reference to bz29590.
bzimport added a subscriber: Unknown Object (MLST).
Aklapper changed the subtype of this task from "Task" to "Feature Request".Feb 4 2022, 12:24 PM
Aklapper removed a subscriber: wikibugs-l-list.