Page MenuHomePhabricator

Shortcut CTRTL+M is not always the correct shortcut
Closed, ResolvedPublic

Description

Toggling IME On/Off on a Mac fails with keyboard shortcut Control M since it minimizes the window in Mac


Version: unspecified
Severity: normal
OS: Mac OS X 10.4
URL: http://ta.wikibooks.org

Details

Reference
bz31026

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:53 PM
bzimport set Reference to bz31026.
bzimport added a subscriber: Unknown Object (MLST).

junu.pv+public wrote:

We can set shortcut we like, but it is very difficult to find a universally applicable one. Chances are there you selected shortcut might be already allocated by some browser.

Did you have any other shortcut that work on all browsers?

I am no Mac person, some one from UX team may have some idea?

Tested Mac OS X 10.7.1, Firefox 6.0.2 -- control+M on ta.wikibooks.org toggles the Narayam state successfully.

Tested Mac OS X 10.7.1, Safari 5.1 -- control+M on ta.wikibooks.org toggles the Narayam state successfully.

Tested Mac OS X 10.7.1, Chrome 14.0.835.163 -- control+M on ta.wikibooks.org toggles the Narayam state successfully.

Note that *Command*+M minimizes windows in all three browsers.

junu.pv+public wrote:

(In reply to comment #3)

Tested Mac OS X 10.7.1, Firefox 6.0.2 -- control+M on ta.wikibooks.org toggles
the Narayam state successfully.

Tested Mac OS X 10.7.1, Safari 5.1 -- control+M on ta.wikibooks.org toggles the
Narayam state successfully.

Tested Mac OS X 10.7.1, Chrome 14.0.835.163 -- control+M on ta.wikibooks.org
toggles the Narayam state successfully.

Note that *Command*+M minimizes windows in all three browsers.

Thanks.

http://tawp.in/r/2na0 Original reporter verified and says its working.

Reopening this bug, as just tested with Santhosh. Very different behaviours in OSX 10.7.2 in different browsers. The help text "CTRL+M" in the collapsable menu for toggling key mapping needs to be dynamic, and possibly on Firefox 7 there is also a duplicate assignment (conflictiong with CRTL+M for page move).

Preconditions:

  • logged into MediaWiki with Narayam installed
  • using a locale that has Narayam enabled by default (for example ta/Tamil)
  • editing page the logged in user is allowed to move

Steps to reproduce:

  1. press CTRL+M in edit mode

Observed behaviours:

  • OSX 10.7.2/Firefox 7.0.1: pressing CTRL+M, Narayam will enable/disable, and immediately after, the page move dialog is loaded.
  • OSX 10.7.2/Opera 11.51: pressing CRTL+M does nothing. Narayam toggle it CRTL+CMD+M. (page move is CRTL+ESC+M)
  • OSX 10.7.2/Safari 5.1.1: pressing CTRL+M enables/disables Narayam. (page move is CTRL+ALT+M.) This is expected behaviour.
  • OSX 10.7.2/Chrome 14.0.835.202: pressing CTRL+M enables/disables Narayam. (page move is CTRL+OPTION+M.) This is expected behaviour.

Expected behaviour:

  • show the proper shortcut for enable/disable in the Input methods menu
  • no duplicate assignment of keyboard shortcuts.

(In reply to comment #6)

  • OSX 10.7.2/Firefox 7.0.1: pressing CTRL+M, Narayam will enable/disable, and

immediately after, the page move dialog is loaded.

For FF and OSX, we changed the shortcut to CTRL+G since CTRL+M is access key defined for page move.

  • OSX 10.7.2/Opera 11.51: pressing CRTL+M does nothing. Narayam toggle it

CRTL+CMD+M. (page move is CRTL+ESC+M)

Changed the shortcut key to CTRL+CMD+M.

In all cases, the shortcut key displayed in Menu is dynamic now. The browser, os sniffing is based on the code in mediawiki.util.js

See r101790