Just like the desktop site. Text input on mobiles suck so lets make it easier by making our users type less.
Version: 1.0.0 (Android)
Severity: enhancement
Description
Description
Details
Details
- Reference
- bz31686
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T33702 Android app shows blank screen after network failure | |||
| Resolved | • Tfinc | T33447 Android App 1.0 release (tracking) | |||
| Resolved | None | T33686 Android app should show search suggestions |
Event Timeline
Comment Actions
Let's re-use whatever we come up with for https://bugzilla.wikimedia.org/show_bug.cgi?id=19956
Comment Actions
Ok, current state is:
- there are no suggestions while you type
- when you submit your search, instead of an actual search we look up the search suggestions based on what you typed.
So basically we need to take the suggestion search that it does now and move that to *while you type*, and then change the final search to do a fulltext search instead of getting typeahead suggestions.
Comment Actions
herman.wong wrote:
https://github.com/nitobi/Wikipedia/commit/435256ffbc1ffc653364be13c7564cdbd1607697
search suggestions display as the user types
Comment Actions
Seems pretty buggy:
- sometimes comes back with seemingly wrong or early results: eg typing "thing" and ending up with suggestions that fit with just the initial "t"
- sometimes all the results disappear from screen
- sometimes navigates to a page before you've completed the search; for instance type "supreme" or "new york" and you may find yourself at those pages.
Comment Actions
Tapping on a suggestion also often closes the list without showing any focus behavior in the list, then focuses & shows a highlight ring on some UI element that was on the page behind, such as a link, until the target page loads.
Comment Actions
herman.wong wrote:
https://github.com/nitobi/Wikipedia/commit/3d429186f9881a6db767040adefb274eccc60d85
this should fix the following symptoms:
- sometimes all the results disappear from screen
- sometimes navigates to a page before you've completed the search; for
instance type "supreme" or "new york" and you may find yourself at those pages.
Comment Actions
Awesome, it's working a lot smoother now. A little tweaking on the click behavior should pretty much do it for now!
Comment Actions
herman.wong wrote:
https://github.com/nitobi/Wikipedia/commit/205829daf164d3e8191b9f33cb5a71a57f059cf3
this should prevent the focus on UI element on the page behind.
Comment Actions
herman.wong wrote:
https://github.com/nitobi/Wikipedia/commit/8c19042190985ddd504173458620c6166999abf7
the search results & search suggestions now have an active state when the item is clicked on.