Page MenuHomePhabricator

Incorrect spacing on messages for Special:EditWatchlist/raw results
Closed, ResolvedPublic

Description

Add spaces between watchlistedit-raw-done, watchlistedit-raw-added, and watchlistedit-raw-removed messages.

When submitting the raw watchlist edit form, the results page displays the watchlistedit-raw-done, watchlistedit-raw-added, and watchlistedit-raw-removed messages with no spaces in between. This results in display along the lines of "Your watchlist has been updated.1 title was added:", missing a space between the two sentences.

The attached patch will fix the issue. If items were both added and removed, the HTML will contain one unnecessary space before the watchlistedit-raw-removed message, but this does not affect the display of the page in the browser.


Version: 1.20.x
Severity: minor

Attached:

Details

Reference
bz32505

Event Timeline

bzimport raised the priority of this task from to Needs Triage.Nov 22 2014, 12:01 AM
bzimport set Reference to bz32505.
bzimport added a subscriber: Unknown Object (MLST).

Hard coding the spaces feels wrong from a localisation/internationalisation side..

Seems we do it already in core. r103709, thanks!

alexsm333 wrote:

Same issue with [[MediaWiki:Prefs-help-email]] and [[MediaWiki:Prefs-help-email-others]] in preferences; hope someone will see this note...

(In reply to comment #3)

Same issue with [[MediaWiki:Prefs-help-email]] and
[[MediaWiki:Prefs-help-email-others]] in preferences; hope someone will see
this note...

Should probably be filed as a new bug, but at the moment it seems these help messages have been completely removed since r92924.