Page MenuHomePhabricator

Lohit-Tamil Font improvements
Closed, DeclinedPublic

Description

We have some improvements on Lohit-Tamil, but am not sure if they are in codeline. r104662 says the version as 2.5, Is this our own version number? especially since Lohit-Tamil we might use will not be there in upstream.

Also parking this bug for more test feedback.

Santhosh,
Can you please confirm the latest version on translatewiki has all the changes you did while we did offline testing?


Version: unspecified
Severity: normal

Details

Reference
bz33085

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:59 PM
bzimport set Reference to bz33085.
bzimport added a subscriber: Unknown Object (MLST).

The version number is from upstream.

(In reply to comment #0)

Santhosh,
Can you please confirm the latest version on translatewiki has all the changes
you did while we did offline testing?

Yes, The font was updated on Nov 29 in r104542 and available for testing in translatewiki.net from the same day. I had communicated this to you in the mail.

(In reply to comment #2)

Yes, The font was updated on Nov 29 in r104542 and available for testing in
translatewiki.net from the same day. I had communicated this to you in the
mail.

I remember seeing the mail, what confuses me is the version number. If its from the upstream, it might not have changes done by you, since IIRC, your changes did not go into upstream.

(In reply to comment #3)

I remember seeing the mail, what confuses me is the version number. If its from
the upstream, it might not have changes done by you, since IIRC, your changes
did not go into upstream.

Upstream does not/need not maintain webfont versions(WOFF,EOT variants) and often releases an SFD. Version number 2.5.0 means, the webfonts were created from the upstream version 2.5.0. Hope it clarifies.
My changes for the webfonts versions can be merged to upstream, but only after some testing and impact on platforms with native hinting. Another option is upstream maintaining Lohit_Tamil_Webfont as separate font.

(In reply to comment #4)

Upstream does not/need not maintain webfont versions(WOFF,EOT variants) and
often releases an SFD. Version number 2.5.0 means, the webfonts were created
from the upstream version 2.5.0. Hope it clarifies.

Does it mean that your hinting workaround fixes were not done on the source(SFD) and done while generating WOFF EOT variants? My only worry is all those changes should be kept somewhere and not lost. Especially if we are planning to continue on Lohit-Tamil

My changes for the webfonts versions can be merged to upstream, but only after
some testing and impact on platforms with native hinting. Another option is
upstream maintaining Lohit_Tamil_Webfont as separate font.

We shall wait and complete this post testing.

Can the delivery also happen based on request headers?
If AutoHintingEnabledOS Then Deliver Original Lohit-Tamil
Else Deliver Touched up Lohit-Tamil

Unrelated to bug, if www.icta.lk fonts or something else comes up soon and is better, we can ditch Lohit-Tamil if that saves time and effort.

(In reply to comment #5)

Does it mean that your hinting workaround fixes were not done on the
source(SFD) and done while generating WOFF EOT variants? My only worry is all
those changes should be kept somewhere and not lost. Especially if we are
planning to continue on Lohit-Tamil

SFD can be created always from the TTF version, and we are keeping it in version control

Can the delivery also happen based on request headers?
If AutoHintingEnabledOS Then Deliver Original Lohit-Tamil
Else Deliver Touched up Lohit-Tamil

I am not aware of any mechanism that allows to check whether autohinting enabled in OS. AFAIK browsers cannot give that much information. There were some attempts by some folks to figure out that by rendeirng a letter in canvas and then checking the rendered letter. Its not a reliable test.

Unrelated to bug, if www.icta.lk fonts or something else comes up soon and is
better, we can ditch Lohit-Tamil if that saves time and effort.

I am not aware of any Tamil fonts they have released, we have checked Bashita font (http://www.icta.lk/en/policy-leadership-and-institutional-development/685-icta-launches-qbhashitaq-font-family.html ) for Sinhala and lit is a closed license font.

Is this fixed with the latest Lohit family updates?

(In reply to comment #7)

Is this fixed with the latest Lohit family updates?

Not really. The intent of the bug was mainly to improve / fix hinting issue(which causes poor readability) and fix the blocker for WebFonts deployment on Tamil Wikiprojects. The recent upstream updates were only fixes to select glyphs on other issues and did not address hinting. Santhosh tried adding hints manually but we found it might not give in optimal results. Marking it as WONTFIX.

We would still like to have Lohit Tamil part of WebFonts as it will not have any issues on a wiki which is accessed in a world without Windows XP/Vista. (But sadly large number people use from Wikimedia wikis from these and hence Wikimedia wikis can't use Lohit-Tamil)