Page MenuHomePhabricator

License selector: <option disabled="disabled"> doesn't work in some browsers
Closed, ResolvedPublic

Description

Author: jepe

Description:
With the new licensing selection menu in special:upload the description above a group
of licenses is rendered in html with <option disabled>. In Firefox this menu-option
is grayed out and not selectable. However in Internet Explorer this menu-option is
displayed normal in black and can be selected just as the other options.

An other possibility what works normal in IE is to use <optgroup> to display a
description for a group of menu-items.

Something else, can it be made possible to assign also a template to the "none"
option if there is no licence selected.


Version: 1.6.x
Severity: normal
Platform: PC
URL: http://en.wikipedia.org/wiki/Special:Upload

Details

Reference
bz3318

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:49 PM
bzimport set Reference to bz3318.
bzimport added a subscriber: Unknown Object (MLST).

avarab wrote:

Well it's not really our problem if Internet Explorer doesn't adhere to the
XHTML specification, but how could the <optgroup> element be used to provide a
workaround?

jepe wrote:

You have however only one indent level and it can be used in the folowing way:
<optgroup label="GNU licenses">
<option ...>
<option ...>
</optgroup>

Firefox is a better browser but the reality is that Internet Explorer is the
most used browser.

Quick survey of <option disabled="disabled"> on Special:Upload

  • IE 6.0 on XPSP2: ignored
  • Safari 2.0.1: ignored
  • IE 5.2/Mac (OS X): disabled works, but the indented entries don't show in the pop-up
  • IE 5.0/Mac (Classic): works
  • Firefox 1.0.6: works
  • Opera 8.02: works
  • Bug 3333 has been marked as a duplicate of this bug. ***
  • IE 7 Beta 1 on XPSP2: ignored

ejsanders wrote:

Yup, another bug in IE, hooray. But seeing as nested groups aren't really
required here, the <optgroup> tag would be the best solution. Note that "all
OPTGROUP elements must be specified directly within a SELECT element (i.e.,
groups may not be nested).", but they do auto indent the groups and emphasise
the labels (in IE as well).

avarab wrote:

(In reply to comment #6)

But seeing as nested groups aren't really required here

But more useful than not having them.

ejsanders wrote:

I don't know if it's intentional, but the nested groups don't do anything at the
moment. Everything is just indented by one level, which is acceptable.

jepe wrote:

I think, a lot of nested groups which are also selectable by the most users,
are very confusing for especially new users. So, a lot of uploads on the Dutch
Wikipedia since there is the license-selector haven't the just license or no
license at all.

It must be impossible to upload a file without selecting a license, also
the 'none selected' option should not be selectable or there must be a template
like {{Unknown}} assigned to.

This is offtopic for this bug, but to reply to the previous comment: we quite
deliberately *do not* block uploads with the no license option, since the
most likely alternative is a lot of absolutely totally 100% non-free material
getting uploaded with false license information because people just click
whatever lets it go through. Then it's harder to track down and delete them.

To suggest alternative behavior, please open a new bug rather than commenting
further here.

  • Bug 4313 has been marked as a duplicate of this bug. ***

I've added a CSS style which makes the disabled items show grayed-out correctly in MSIE/Windows.

Additionally, a JavaScript hack will revert the selector to "None selected" if you actually select one of the disabled items.
There might be further improvements which can be made here.

Safari still doesn't show the disabled items as gray, but the hack to prevent them from being selected is there, and
should be at least a bit of a cue to users that their selection didn't take.

Another JavaScript hack seems to fix the display problem in MSIE/Mac. (Setting the option text to itself... oh what a
lovely bug!)

I guess this should have been set to FIXED?