| TheDJ | |
| Jan 22 2012, 5:22 AM |
| F8470: patch.diff | |
| Nov 22 2014, 12:00 AM |
The JS of wikisource is not including the right dependencies to work icw with 1.19 deploy it seems
Version: unspecified
Severity: blocker
URL: http://en.wikisource.beta.wmflabs.org/w/index.php?title=Page:Wind_in_the_Willows_(1913).djvu/28&action=edit&redlink=1&debug=true
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T33217 MediaWiki bugs to be fixed for 1.19wmf1 deployment (tracking) | |||
| Resolved | None | T35873 Proofread extension JS loading fully broken on 1.19 |
dependency in proofread, to force loading of wikibits in debug mode (due to async bug in debug mode that Krinkle pointed out to Catrope). With that, we might be able to figure out why it's not working in production, since no console errors are shown.
zaran.krleza wrote:
yes, I'm going to take a look at it some time this week. As Derk-Jan pointed out, it is only a problem of wikibits dependency, and the time at which it is loaded. It seems to work on the lab server by adding wikibits as a dependency of the ProofreadPage extension (it is currently not the case in the code in the SVN repository).
(In reply to comment #4)
yes, I'm going to take a look at it some time this week
Are you on IRC? Could you ping me (hexmode on MediaWiki-General) if you start to work on this?
zaran.krleza wrote:
add wikibits as a dependency of ProofreadPage extension
Attached:
zaran.krleza wrote:
Yes I'm on IRC (Zaran on MediaWiki-General). I've started working on it yesterday.
There are two ways to solve the problem :
above).
I don't know if the option $wgIncludeLegacyJavascript is planned to be set to
true on the deployment servers. But in all cases, it's probably better to add
the dependency to wikibits, because the current javascript code of the
extension relies on some deprecated functions (hookEvent for example).
Patch was applied, but apparently it's still not working on labs. I also committed r110691, but this didn't seem to fix it on labs either.
http://en.wikisource.beta.wmflabs.org/wiki/Page:Wind_in_the_Willows_%281913%29.djvu/28 works for me now in the sense that I don't get any JS errors when I view it; I'm not familiar with ProofreadPage so maybe there are missing features I'm not aware of?
Is this still broken, and if so, how do I reproduce?
zaran.krleza wrote:
It is still broken: in the proofreadpage extension, you're supposed to see the image of the page on the right side of the text.
See for example on fr.wikisource: http://fr.wikisource.org/wiki/Page:Leblanc_-_L’Île_aux_trente_cercueils.djvu/8
or on the wikisource instance on labs: http://wikisource-dev.wmflabs.org/w/index.php/Page:Bloy_-_Sueur_de_sang.djvu/227
Note that currently the bug doesn't show up when you test locally or on the wikisource instance on labs. But on the deployment instance, the proofreadpage specific javascript simply doesn't load without any error.
Note also that with &debug=true the bug disappears. But looking at the compressed javascript with &debug=false, it looks like the javascript of the extension is not even included.