Page MenuHomePhabricator

[Regression] Edit links seen on previous page versions
Closed, ResolvedPublic

Description

From https://en.wikipedia.org/w/index.php?diff=479580769 :

when I'm looking at an old revision of a page there are edit section links available, however when I click on one it takes me to editing the same numbered section, but of the current revision, not the old revision that I was looking at (does that make sense?). So, is this a new thing or has it always been like that?

It's new. It occurs for all sections on all pages I tested but an example can be good anyway: http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=478913156#Article_counter currently has a section edit link saying http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&action=edit&section=50.


Version: 1.19
Severity: normal

Details

Reference
bz34841

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 12:14 AM
bzimport set Reference to bz34841.

I can't reproduce this on enwiki. I don't see [edit] links.

(In reply to comment #3)

I can't reproduce this on enwiki. I don't see [edit] links.

I can reproduce using the link http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=478913156#Article_counter

I can reproduce both logged in and logged out. Maybe you have some pref preventing them from appearing?

I do see the edit links on that link.

this is already fixed in trunk, we need to find it and merge it :)

I note this was resolved by removing the edit links again and although the correct (old) edit text appears if you do add the oldid parameter as I suggested, it is the right thing to not include these edit links at the moment because the edit is matched against the current version's same section number, as can be seen by clicking on my link above and then showing changes.

Nevertheless, for some pages, especially articles, where the sectioning doesn't change as much it does still seem like a good option, perhaps only available by a manually added parameter to the old revision URL.