Maniphest T36849

diff during editing an old version compares not to the current but to the old version
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	• bzimport
	Mar 1 2012, 1:26 PM

Tags

Referenced Files

None

Subscribers

MarkAHershberger

Description

Author: saibotrash

Description:
See [[:commons:Commons:Village pump#MW1.19 - editing old revision and "show changes" does not work]] for maybe more comments by other users.

Test: [//commons.wikimedia.org/w/index.php?title=File:P1000372_dsdssdd_ds.JPG&action=edit&oldid=61901086 edit], click compare button below the edit window. Expected: for example the first two "wrong licensing" lines should appear as deleted in the diff.

Editing works - but the comparision apparently compares not with the current version (like before 1.19) but with the version you had edited. That is not useful since what will be overwritten when the save is done is the current version.

Version: 1.19
Severity: normal
URL: http://commons.wikimedia.org/w/index.php?title=Commons:Village_pump&oldid=67735979#MW1.19_-_editing_old_revision_and_.22show_changes.22_does_not_work

Details

Reference: bz34849

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		None	T33217 MediaWiki bugs to be fixed for 1.19wmf1 deployment (tracking)
		Resolved		None	T36849 diff during editing an old version compares not to the current but to the old version

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 12:15 AM

• bzimport added projects: MW-1.19.0-release, MediaWiki-Page-diffs.

• bzimport set Reference to bz34849.

• bzimport added a subscriber: Unknown Object (MLST).

• bzimport created this task.Mar 1 2012, 1:26 PM

Perma link, to the discussion:

http://commons.wikimedia.org/w/index.php?title=Commons:Village_pump&oldid=67735979#MW1.19_-_editing_old_revision_and_.22show_changes.22_does_not_work

Confirmed. Step to reproduce:

create a new page with text: "this is first revision". Save page.

Edit page and append text "this is second revision". Save page.

Browse to history, select the oldest revision. The loaded page show "this is first revision".

Edit page and append "this is third revision". Press [Show change]

The diff loaded is:

This is the very first revision.

+ This is third revision

It does not show the removal of the second revision text.

cause by some change in r102997 by iAlex which cleaned up Article::view()

Fixed in r112819.

Merged in 1.19wmf1 by r112821 and deployed live.

saibotrash wrote:

Confirmed, my testcase works. thanks!

He7d3r mentioned this in T37067: Provide an easy way to get a diff against an old revision of a page while editing it.Dec 22 2015, 1:19 PM

Aklapper added a project: MediaWiki-Page-history.Sep 20 2019, 7:47 PM

Aklapper removed a subscriber: • wikibugs-l-list.

matmarex mentioned this in T315716: Visual editor diff behavior is different from wikitext editor behavior when editing an old revision (diff to start revision vs latest revision).Aug 20 2022, 2:15 AM