Page MenuHomePhabricator
Create Task
Maniphest T48493

Special:ProtectedPages results in whitepage when a bad title is protected
Closed, ResolvedPublic
Actions

Description

Ran into this on wiki.mozilla.org -- SpecialProtectedPages.php doesn't check the result of Title::makeTitleSafe(), so when it returns null (as it does if an error occurs) then [[Special:ProtectedPages]] errors out.

Version: 1.19.4
Severity: normal
URL: https://bugzilla.mozilla.org/show_bug.cgi?id=853625

Details

Reference
bz46493

Event Timeline

• bzimport raised the priority of this task from to High.Nov 22 2014, 1:14 AM
• bzimport added projects: MW-1.19-release, MediaWiki-Page-protection.
• bzimport set Reference to bz46493.
• bzimport added a subscriber: Unknown Object (MLST).
MarkAHershberger created this task.Mar 23 2013, 8:29 PM
Nemo_bis added a comment.Mar 24 2013, 2:38 AM

https://gerrit.wikimedia.org/r/#/c/55491/

Umherirrender added a comment.Mar 27 2013, 10:36 AM

Maybe someone can run the cleanupTitles.php maintenance script on that wiki to fix the broken rows.

Umherirrender added a comment.Mar 27 2013, 11:32 AM

commited a alternative with gerrit 56125

Umherirrender added a comment.Mar 27 2013, 1:09 PM

(In reply to comment #3)

commited a alternative with Gerrit change #56125

successfully merged, so FIXED in master

gerritbot added a comment.Apr 7 2013, 8:29 PM

Related URL: https://gerrit.wikimedia.org/r/57936 (Gerrit Change Iaa6e3378c185c53b77a4ede0ddfdfed8c6a2268a)

MarkAHershberger added a comment.May 7 2013, 1:47 PM

oops, need to check that this is in 1.19

gerritbot added a comment.May 7 2013, 2:46 PM

Related URL: https://gerrit.wikimedia.org/r/62608 (Gerrit Change Iaa6e3378c185c53b77a4ede0ddfdfed8c6a2268a)

gerritbot added a comment.Mar 26 2014, 1:05 PM

Change 62608 abandoned by MarkAHershberger:
Handle invalid titles on ProtectedPages and ProtectedTitles

Reason:
clean up

https://gerrit.wikimedia.org/r/62608

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL