Page MenuHomePhabricator

[TUX] [IE9] Placeholder is used as instant filter
Closed, ResolvedPublic

Description

Screenshot of initial view with filtered list

In IE9, the "Filter list" text that is in the field as a placeholder, is immediately used as a filter (also in earlier versions of IE).

Steps to reproduce:

  1. Go to URL.

Observed:
I. List appears to be filtered. See screenshot.

Expected:
II. List should only be filtered if a user adds text to filter on.


Version: master
Severity: critical
URL: https://translatewiki.net/w/i.php?title=Special:Translate&group=page-0-all&language=nl&filter=translated&action=translate&uselang=en&debug=true
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=47057

Attached:

Schermafbeelding_2013-04-09_om_14.32.34.png (210×1 px, 48 KB)

Details

Reference
bz47039

Event Timeline

bzimport raised the priority of this task from to Unbreak Now!.Nov 22 2014, 1:23 AM
bzimport set Reference to bz47039.

Related URL: https://gerrit.wikimedia.org/r/58301 (Gerrit Change Ib483b4d15034eaf726a7a0d42ab4f5170fc5abde)

My understanding is that it happens because in IE jquery.placeholder is applied to all the fields on the page in resources/mediawiki.page/mediawiki.page.ready.js and causes .val() to return the placeholder text.

As an experiment, I tried replacing the core jquery.placeholder.js with the plugin of the same name from here:
https://github.com/mathiasbynens/jquery-placeholder

Everything just worked, including the placeholder in the search box.

Related URL: https://gerrit.wikimedia.org/r/58423 (Gerrit Change If3a035c3f07723c6e25eac1b2d829a85dc9b481f)