Page MenuHomePhabricator
Create Task
Maniphest T51881

NaturalLanguageList parser tests do not pass on HHVM
Closed, DeclinedPublic
Actions

Description

Jenkins build result showing the parsertests errors

I have added parsertests in Jenkins and they do not pass. The original test was report:

file_49881.txt16 KBDownload
it has been fixed by https://gerrit.wikimedia.org/r/323390

The parser tests fail when run under HHVM though:

ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Regular use, one item"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Regular use, two items"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Regular use, two items, alternate syntax"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Regular use, four items"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Duplicates allowed"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Duplicates not allowed"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Blanks not allowed"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Blanks allowed"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Blanks allowed, but no duplicates"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Output separator, basic with spaces"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Output separator, basic without spaces"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Output separator, together with rawlist"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Output separator with different last separator"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Only last separator"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Sophisticated separator input"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Basic format"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Basic format with link"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Set fieldsperitem"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Calculate fieldsperitem"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Calculate fieldsperitem; 3"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Overwritted calculated fieldsperitem input upward"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Overwritted calculated fieldsperitem input downward"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Basic rawlist input"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Basic rawlist input with ignore"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Rawlist input in two elements"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Rawlist input in two elements with two ignored elements"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Basic ignore scenario"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Ignoring wikilinks"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Overwriting ignore with data"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Range"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Negative range"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Positive range with step"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Negative range with step"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Negative range with false step"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Forced length"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: No range"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Don't reach higher than capped length"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Don't reach higher than capped length, not even with forced length"
ParserTest_NaturalLanguageList__nllParserTests.testParse with data set "nllParserTests.txt: Fail on attempt to create too large a list."

Details

Reference
bz49881
SubjectRepoBranchLines +/-
Adjust parserTests expected outputmediawiki/extensions/NaturalLanguageListmaster+0 -6
Customize query in gerrit

Event Timeline

• bzimport raised the priority of this task from to Lowest.Nov 22 2014, 1:42 AM
• bzimport added a project: MediaWiki-extensions-Other.
• bzimport set Reference to bz49881.
hashar created this task.Jun 20 2013, 3:17 PM
• bzimport added a comment.Jul 4 2013, 1:02 PM

svippy wrote:

The first three looks to be an issue with deprecated functions in 1.21, while the latter two seem to be a change of how MediaWiki handles empty lines.

hashar updated the task description. (Show Details)Nov 24 2016, 1:26 PM
hashar set Security to None.
gerritbot subscribed.Nov 24 2016, 1:35 PM

Change 323390 had a related patch set uploaded (by Hashar):
Adjust parserTests expected output

https://gerrit.wikimedia.org/r/323390

gerritbot added a project: Patch-For-Review.Nov 24 2016, 1:35 PM

Change 323390 merged by jenkins-bot:
Adjust parserTests expected output

https://gerrit.wikimedia.org/r/323390

hashar added a comment.Nov 24 2016, 1:36 PM

https://gerrit.wikimedia.org/r/#/c/323390/ adjust the expected output of parser tests. It pass fine with PHP Zend 5.5 but that somehow fails entirely when using HHVM :(

hashar updated the task description. (Show Details)Nov 24 2016, 1:38 PM
hashar renamed this task from NaturalLanguageList parser tests do not pass to NaturalLanguageList parser tests do not pass on HHVM.Nov 24 2016, 1:41 PM
hashar edited projects, added HHVM; removed Patch-For-Review.
hashar closed this task as Declined.Sep 21 2018, 9:12 PM

Extension does not seem to have received much code update over the last 5 years and HHVM is legacy.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL