SpecialPasswordReset when called does not obey an optional returnto parameter
Closed, ResolvedPublic
Actions

Assigned To

None

Authored By

	Wikinaut
	Nov 15 2013, 10:19 AM

Description

Observed, that the returnto= parameter is ignored.

https://en.wikipedia.org/w/index.php?title=Special:PasswordReset&returnto=Special:UserLogin

is ignored.

SpecialPasswordReset.php lines 301-316

Perhaps this comes from the missing parameter passing, and simply and always returning to the Main page in
https://git.wikimedia.org/blob/mediawiki%2Fcore.git/146ea32031dba266831d0f7820f2bc8214f34a58/includes%2Fspecials%2FSpecialPasswordReset.php#L316

public function onSuccess() {

...

		$this->getOutput()->addWikiMsg( 'passwordreset-emailsent' );
		$this->getOutput()->returnToMain();

}

I need the PasswordReset with a working returnto for several bugfixes for E:OpenID.

Version: 1.23.0
Severity: normal
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=33997
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289

Details

Reference: bz57098

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:13 AM

• bzimport added a project: MediaWiki-User-login-and-signup.

• bzimport set Reference to bz57098.

• bzimport added a subscriber: Unknown Object (MLST).

Wikinaut created this task.Nov 15 2013, 10:19 AM

Fixed in https://gerrit.wikimedia.org/r/96253

I suggest to backport this fix and then to check whether it solves the https://bugzilla.wikimedia.org/show_bug.cgi?id=57289 .

Unsure, whether I have to reopen this bug. I reopen it provisionally.

(In reply to comment #2)

I suggest to backport this fix and then to check whether it solves the
https://bugzilla.wikimedia.org/show_bug.cgi?id=57289 .

You can check whether this fixes that issue on any of the wikis that have 1.23wmf5, which, as of Fri Nov 22nd is:
test.wikipedia.org
test2.wikipedia.org
mediawiki.org
test.wikidata.org

And always, you can test whatever is in master (merged), after about 5 minutes after it's merged, on the Beta Cluster:
eg: en.wikipedia.beta.wmflabs.org

Let me know what you find out.

In www.mediawiki,org : Not solved

After changing the password, see http://i.imgur.com/7ADHPHH.png

URL:

https://www.mediawiki.org/w/index.php?title=Special:ChangePassword&returnto=&returntoquery=&fromhttp=1

Problem is not solved, in my view.

Working correctly on mediawiki.org; closing the bug again.

(In reply to comment #5)

Working correctly on mediawiki.org; closing the bug again.

Do you mean it is correct to see http://i.imgur.com/7ADHPHH.png after correctly having changed the temporary to the new password ?

It would be better to guide the user and to show then a page saying "You have successfully changed your password. Please log in with the new password."

and to present a link to SpecialUserLogin there.

(In reply to comment #6)

Do you mean it is correct to see http://i.imgur.com/7ADHPHH.png after
correctly
having changed the temporary to the new password ?

(In reply to comment #7)

It would be better to guide the user and to show then a page saying "You have
successfully changed your password. Please log in with the new password."

and to present a link to SpecialUserLogin there.

This bug is about Special:PasswordReset; not Special:ChangeEmail.

(In reply to comment #8)

(In reply to comment #6)

Do you mean it is correct to see http://i.imgur.com/7ADHPHH.png after
correctly
having changed the temporary to the new password ?

(In reply to comment #7)

It would be better to guide the user and to show then a page saying "You have
successfully changed your password. Please log in with the new password."

and to present a link to SpecialUserLogin there.

This bug is about Special:PasswordReset; not Special:ChangeEmail.

Yes. It is! This is Special:PasswordReset!

This is why I am saying, respectfully stated, you are wrong, that this is solved, in my view, it is not solved.

No commits to backport, reopen if there should be any.

SpecialPasswordReset when called does not obey an optional returnto parameterClosed, ResolvedPublicActions

Description

Details

Event Timeline

SpecialPasswordReset when called does not obey an optional returnto parameter
Closed, ResolvedPublic
Actions