Page MenuHomePhabricator
Create Task
Maniphest T59826

SyntaxHighlight should not convert tabs to 8 spaces
Closed, ResolvedPublic
Actions

Description

Now that bug 39616 is fixed, the SyntaxHighlight extension is converting every tab to a series of eight spaces. This transformation prevents the fix for bug 57824 from having any effect on <source> tags. It's also inconsistent with the CodeEditor extension, which displays tabs as four spaces and binds the Tab key to the tab character (bug 39616). While an eight-character wide tab may make sense in some contexts, replacing a tab with eight spaces would seem contrary to user intent in the vast majority of cases.

Possibly a regression of bug 30930?

Version: unspecified
Severity: normal
URL: https://www.mediawiki.org/wiki/User:Mxn/57826

Details

Reference
bz57826

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 22 2014, 2:36 AM
• bzimport added a project: SyntaxHighlight.
• bzimport set Reference to bz57826.
• bzimport added a subscriber: Unknown Object (MLST).
mxn created this task.Dec 2 2013, 3:54 AM
mxn added a comment.Dec 2 2013, 4:04 AM

Naturally, this bug breaks GeSHi's support for the Whitespace language, as seen in the URL above.

Anomie added a comment.Dec 2 2013, 3:59 PM

(In reply to comment #0)

Possibly a regression of bug 30930?

No, it's not. Bug 30930 was that Tidy's tabs-to-spaces change was making code be unaligned, and that was fixed by converting tabs-to-spaces before highlighting the code.

gerritbot added a comment.Dec 2 2013, 4:42 PM

Change 98540 had a related patch set uploaded by Anomie:
Protect tabs from HTML Tidy

https://gerrit.wikimedia.org/r/98540

gerritbot added a comment.Dec 2 2013, 7:18 PM

Change 98540 merged by jenkins-bot:
Protect tabs from HTML Tidy

https://gerrit.wikimedia.org/r/98540

Anomie added a comment.Dec 2 2013, 7:27 PM

Patch is merged, and should be deployed to WMF wikis with 1.23wmf6. See https://www.mediawiki.org/wiki/MediaWiki_1.23/Roadmap for the schedule.

Aklapper removed subscribers: Anomie, • wikibugs-l-list.Oct 16 2020, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL