When using the --schema option post-db maintenance scripts should not be run as they talk to the database directly and do not use DatabaseUpdater.
Currently if you use the Flow or WikiData extensions and pass --schema without an already initialized database it will error out since their maintenance scripts are trying to talk to an empty databse.
The use case for --schema is within jenkins to log the sql that was used within the test instance.
Version: 1.24rc
Severity: normal
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Clean up mw scripts | integration/jenkins | master | +37 -55 |
Thanks Erik, I have posted on wikitech-l:
arlier today I slightly changed how Jenkins run the MediaWiki extension job. Specifically the way the database is updated.
We used to simply:
php maintenance/update.php
I wanted to log the SQL queries behind added to the database and the script has a --schema option to do just that. So Jenkins now:
php maintenance/update.php --schema update_sql.log
sleep 1
php maintenance/update.php
The sleep is needed because --schema still write to the update_log database. The two runs ends up having the same ul_key in the table since it just vary by timestamp (so if two run occurs in the same second, the second has a duplicate key error).
There should be a better fix, but sleep 1 works ™
Flow had an issue with the tests failing because --schema still run the post-db maintenance script (might be the cause of above problem).
Erik Bernhardson figured out a temporary workaround for Flow:
Change 142382 had a related patch set uploaded by EBernhardson:
update.php --schema should not call maint scripts
Change 142383 had a related patch set uploaded by Hashar:
Revert "Use mw-run-update-script.sh script"
Change 142383 abandoned by Hashar:
Revert "Use mw-run-update-script.sh script"
Reason:
Will hack the bin/mw-run-update-script.sh slave script instead. This way we don't have to update all the jobs in Jenkins.
Change 142386 had a related patch set uploaded by Hashar:
Skip update.php --schema for now
Change 142382 abandoned by EBernhardson:
update.php --schema should not call maint scripts