tvignaud wrote:

fix a wrong test

Attached:

jimmy.collins wrote:

See message below "Superuser password:" field in installer:

If the database user specified above does not exist, or does not have access to
create the database (if needed) or tables within it, please provide details of a
superuser account, such as root, which does. Leave the password set to - if this
is not needed.

tvignaud wrote:

This is totally off-topic.

The fact is that with 1.7.1:

• I didn't fill superuser fields
• adding debug statements showed that mediawiki did go in the superuser code

paths and thus tried to create the database with "@localhost"

tvignaud wrote:

... which of course failed.
Looking at what it does, it assumes that root password is initialized to "-"
but in my case, it was set to "", hence the failed test, hence the try to use
a non specified superuser account, thus the faillure.

I think you may be misunderstanding how the installer works. The superuser
account will be used *unless* the password is equal to a single dash. It does
not matter what your actual password is - just leave it as a single dash and the
superuser account will not be used. If you want the superuser account to be
used, change the password from a single dash to the actual password.

robchur wrote:

I should have used a checkbox, like Brion told me to...

robchur wrote:

...and in that vein, I've added one. As of r18549, the superuser account will
not be used unless the appropriate checkbox is selected during the initial form
completion. This should be much clearer than a check based on an obscure default
value.