Page MenuHomePhabricator

Fonts for Japanese and Chinese must be installed for VisualEditor localized screenshots
Closed, ResolvedPublic

Description

Fonts for Japanese and Chinese must be installed for VisualEditor localized screenshots. Without this all the screenshots in these languages show squares instead of the correct characters.


Version: unspecified
Severity: normal

Details

Reference
bz69535

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 22 2014, 3:29 AM
bzimport set Reference to bz69535.

Moving to Wikimedia -> Quality. Will have to figure out the font packages to install. Maybe we could reuse the one defined in puppet class mediawiki::multimedia::fonts

Change 154086 had a related patch set uploaded by KartikMistry:
Add Chinese fonts for VE screenshots feature

https://gerrit.wikimedia.org/r/154086

"fonts-wqy-zenhei" is available on Trusty but not Precise:

[mw1001:~] $ cat /etc/issue
Ubuntu 12.04.4 LTS \n \l

[mw1001:~] $ apt-get --dry-run install fonts-wqy-zenhei
NOTE: This is only a simulation!
      apt-get needs root privileges for real execution.
      Keep also in mind that locking is deactivated,
      so don't depend on the relevance to the real current situation!
Reading package lists... Done
Building dependency tree
Reading state information... Done
Package fonts-wqy-zenhei is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
is only available from another source

E: Package 'fonts-wqy-zenhei' has no installation candidate

Daniel Z. pointed out that "ttf-wqy-zenhei" works as a package name on both Precise and Trusty. On Trusty, it is a virtual package that depends on "fonts-wqy-zenhei", to make migration easier. And, in fact, we already install it:

https://github.com/wikimedia/operations-puppet/blob/8f14fc7cdbfb5c6f16cb4b1a3bbc64dfd5d200e8/modules/mediawiki/manifests/multimedia.pp#L91

Vikas, Amir, are Japanese and Chinese screenshots now good?

(In reply to Željko Filipin from comment #5)

Vikas, Amir, are Japanese and Chinese screenshots now good?

ping :)

Change 154086 abandoned by Dzahn:
Add Chinese fonts for VE screenshots feature

Reason:
abandoning because the related bug is resolved. also it's easy to restore if needed. cheers, Daniel

https://gerrit.wikimedia.org/r/154086

The jobs as they are configured now run on Sauce, whee we cannot control the fonts.

We need to run the jobs on a machine where we can install the required fonts.

Change 162569 had a related patch set uploaded by Zfilipin:
WIP reproducing bug 69535

https://gerrit.wikimedia.org/r/162569

Change 162569 abandoned by Zfilipin:
WIP reproducing bug 69535

https://gerrit.wikimedia.org/r/162569

Change 162576 had a related patch set uploaded by Zfilipin:
WIP [BrowserTest] reproducing bug 69535

https://gerrit.wikimedia.org/r/162576

Change 162576 abandoned by Zfilipin:
WIP [BrowserTest] reproducing bug 69535

https://gerrit.wikimedia.org/r/162576

Kartik proposed a change to add the font 'fonts-wqy-zenhei' https://gerrit.wikimedia.org/r/#/c/154086/ but it has been abandoned.

Daniel Zahn pointed out it is made by https://github.com/wikimedia/operations-puppet/blob/8f14fc7cdbfb5c6f16cb4b1a3bbc64dfd5d200e8/modules/mediawiki/manifests/multimedia.pp#L91

But:

hashar@integration-slave1002:~$ apt-cache policy ttf-wqy-zenhei
ttf-wqy-zenhei:

Installed: (none)
Candidate: 0.9.45-3.1ubuntu1
Version table:
   0.9.45-3.1ubuntu1 0
      500 http://nova.clouds.archive.ubuntu.com/ubuntu/ precise/main amd64 Packages

So apparently mediawiki::packages::fonts is not applied on the continuous integration slaves though we include ::mediawiki::packages , we apparently need to explicitly add that puppet class.

Change 162604 had a related patch set uploaded by Hashar:
contint: labs slaves +mediawiki::packages::fonts

https://gerrit.wikimedia.org/r/162604

I have installed the puppet patch on all jenkins instances:

Info: Applying configuration version '1411572497'
Notice: /Stage[first]/Apt::Update/Exec[/usr/bin/apt-get update]/returns: executed successfully
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-tamil-fonts]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-takao-mincho]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[xfonts-75dpi]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-liberation]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[xfonts-100dpi]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-ubuntu-font-family]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-lyx]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-punjabi-fonts]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-sil-ezra]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-kochi-gothic]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[culmus-fancy]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-sil-nuosusil]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-lklug-sinhala]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-wqy-zenhei]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-takao-gothic]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-mgopen]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-arphic-uming]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[culmus]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-malayalam-fonts]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-vlgothic]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-gujarati-fonts]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-lao]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-telugu-fonts]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-kannada-fonts]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-unfonts-extra]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-oriya-fonts]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-linuxlibertine]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[xfonts-mplus]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-sil-abyssinica]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-thai-tlwg]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-sil-scheherazade]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-arphic-ukai]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-sil-padauk]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-bengali-fonts]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-kacst]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-khmeros]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-kochi-mincho]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-tibetan-machine]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-nafees]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-manchufont]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[xfonts-base]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-devanagari-fonts]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Apt::Noupgrade/Package[update-manager-core]/ensure: removed
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-dejavu-extra]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-farsiweb]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[fonts-arabeyes]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[ttf-alee]/ensure: ensure changed 'purged' to 'present'
Notice: /Stage[main]/Mediawiki::Packages::Fonts/Package[xfonts-scalable]/ensure: ensure changed 'purged' to 'present'
Notice: Finished catalog run in 636.32 seconds

Thanks Antoine, screenshots are fine now! :)

Change 162604 merged by Filippo Giunchedi:
contint: labs slaves +mediawiki::packages::fonts

https://gerrit.wikimedia.org/r/162604

Change 162869 had a related patch set uploaded by Zfilipin:
Running language screenshot job using local Firefox

https://gerrit.wikimedia.org/r/162869

Change 162869 merged by jenkins-bot:
Running language screenshot job using local Firefox

https://gerrit.wikimedia.org/r/162869

Amir can we close this bug or maybe we can keep it open to track the installation of fonts for all the other languages?

I'm closing this. Installing fonts in the future should be simple enough... I think :)

Thanks a lot for the help!