Page MenuHomePhabricator
Create Task
Maniphest T72851

Global renames should leave local log entries on affected wikis
Closed, ResolvedPublic
Actions

Description

Especially with bug 70850, it is very hard to keep track of global renames. Thus, I believe it should be considered to leave a local log entry on Special:Log/renameuser each time a global rename affects the wiki, for convenience of the local users.
Currently, the only local log entry is left in Special:Log/move, but only in case the renamed user had a user page on that particular wiki. I believe users without a userpage should not be put at a disadvantage and as well get at least one log entry.

Version: unspecified
Severity: enhancement

Details

Reference
bz70851
SubjectRepoBranchLines +/-
Move logging inside of RenameuserSQLmediawiki/extensions/Renameuserwmf/1.25wmf21+46 -19
Move logging inside of RenameuserSQLmediawiki/extensions/Renameuserwmf/1.25wmf22+46 -19
Move logging inside of RenameuserSQLmediawiki/extensions/Renameusermaster+46 -19
Update for RenameuserSQL changesmediawiki/extensions/CentralAuthmaster+12 -1
Customize query in gerrit

Related Objects

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 22 2014, 3:44 AM
• bzimport added a project: MediaWiki-extensions-CentralAuth.
• bzimport set Reference to bz70851.
• bzimport added a subscriber: Unknown Object (MLST).
Vogone created this task.Sep 15 2014, 4:47 PM
Legoktm added a comment.Sep 17 2014, 5:20 PM

I don't like the idea of putting a permanent log entry on every single wiki, there are plenty of other actions that would affect the wiki but are only logged on meta (or commons).

Instead I think we should do something similar to what Wikidata does, where it inserts entries into the recentchanges table, so it'll show up on Special:RecentChanges and watchlists for 30 days, and then disappear. Does that sounds reasonable?

Vogone added a comment.Sep 17 2014, 6:03 PM

(In reply to Kunal Mehta (Legoktm) from comment #1)

I don't like the idea of putting a permanent log entry on every single wiki,
there are plenty of other actions that would affect the wiki but are only
logged on meta (or commons).

Is there any reason for it? And anyway, logging one half of the action on meta (the rename itself) and the other half of the action locally (resulting page moves) seems somewhat inconsistent to me. MassMessage for example also leaves an entry in the page histories (like a normal local edit), so why would it be bad if an actual local rename was also logged as such in the appropriate local log?

Samat added a comment.Oct 28 2014, 10:13 PM

(In reply to Kunal Mehta (Legoktm) from comment #1)

I don't like the idea of putting a permanent log entry on every single wiki,
there are plenty of other actions that would affect the wiki but are only
logged on meta (or commons).

In my understanding not on every single wiki. It would only affect wikis where the user registered (or visited at least one time). In this case a log entry about the rename sounds sense for me.

Ajraddatz added a comment.Oct 29 2014, 12:07 AM

Legoktm's idea sounds good to me.

Xeno added a comment.Nov 6 2014, 6:40 PM

I would prefer a local permanent log entry. In the past, such would be available with local renames; I see no reason for it to be unavailable in a global rename (which is basically just batch renames on the target wikis).

Snowolf added a comment.Nov 7 2014, 5:24 AM

I'm not sure why a local entry would help with anything. With SUL finalization, usernames are supposed to be global in nature, and as such the entry should be recorded globally and not locally.

However, I feel that a better way of tracking a user's rename history is useful (due to the limitations of the current global logs) but should be implemented at a global level rather than locally.

• werdna unsubscribed.Dec 10 2014, 5:45 PM
gerritbot subscribed.Mar 18 2015, 6:00 PM

Change 197681 had a related patch set uploaded (by Legoktm):
Move logging inside of RenameuserSQL

https://gerrit.wikimedia.org/r/197681

gerritbot added a project: Patch-For-Review.Mar 18 2015, 6:00 PM

Change 197683 had a related patch set uploaded (by Legoktm):
Update for RenameuserSQL changes

https://gerrit.wikimedia.org/r/197683

Legoktm claimed this task.Mar 18 2015, 6:03 PM
Legoktm added a project: MediaWiki-Core-Team.
Legoktm set Security to None.
Legoktm moved this task from Backlog to Needs Review/Feedback on the MediaWiki-Core-Team board.
gerritbot added a comment.Mar 18 2015, 8:50 PM

Change 197681 merged by jenkins-bot:
Move logging inside of RenameuserSQL

https://gerrit.wikimedia.org/r/197681

gerritbot added a comment.Mar 18 2015, 9:01 PM

Change 197683 merged by jenkins-bot:
Update for RenameuserSQL changes

https://gerrit.wikimedia.org/r/197683

Legoktm closed this task as Resolved.Mar 18 2015, 9:01 PM
Legoktm moved this task from Needs Review/Feedback to Done on the MediaWiki-Core-Team board.
Legoktm mentioned this in T93214: Back-fill log entries from GlobalRenameQueue renames that promoted to a global account.Mar 19 2015, 4:17 PM
gerritbot added a comment.Mar 19 2015, 6:53 PM

Change 197981 had a related patch set uploaded (by Legoktm):
Move logging inside of RenameuserSQL

https://gerrit.wikimedia.org/r/197981

gerritbot added a comment.Mar 19 2015, 6:54 PM

Change 197982 had a related patch set uploaded (by Legoktm):
Move logging inside of RenameuserSQL

https://gerrit.wikimedia.org/r/197982

gerritbot added a comment.Mar 19 2015, 6:54 PM

Change 197981 merged by jenkins-bot:
Move logging inside of RenameuserSQL

https://gerrit.wikimedia.org/r/197981

gerritbot added a comment.Mar 19 2015, 6:54 PM

Change 197982 merged by jenkins-bot:
Move logging inside of RenameuserSQL

https://gerrit.wikimedia.org/r/197982

Legoktm mentioned this in rECAU6b889b9b9b54: Update for RenameuserSQL changes.Mar 23 2015, 3:54 PM
Diffusion mentioned this in rMEXT1432c412d75d: Updated mediawiki/extensions Project: mediawiki/extensions/CentralAuth….Mar 23 2015, 3:55 PM
Legoktm mentioned this in rMEXT9a840a1b92ed: Updated mediawiki/extensions Project: mediawiki/extensions/Renameuser….Mar 23 2015, 3:55 PM
Legoktm mentioned this in rEREN8a8834bd6239: Move logging inside of RenameuserSQL.
Legoktm mentioned this in rEREN9e12874b6ff3: Move logging inside of RenameuserSQL.
Legoktm mentioned this in rERENe2688742e508: Move logging inside of RenameuserSQL.
bd808 moved this task from Done to Archive on the MediaWiki-Core-Team board.Mar 24 2015, 11:04 PM
Legoktm merged a task: T740: [Bug 70851] Global renames should leave local log entries on affected wikis.Mar 30 2015, 8:46 PM
MarcoAurelio moved this task from Backlog to Done on the MediaWiki-extensions-CentralAuth board.May 5 2015, 5:51 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL