Page MenuHomePhabricator

RecentChange::notifyEdit
Closed, ResolvedPublic

Description

Author: dallan

Description:
This seems crazy, but in RecentChange::notifyEdit, the test for ($bot ==
'default') evaluates to true when $bot is passed in as true. I'm on Php 5.1.1.
I changed the test to (strcmp($bot,'default')==0) and that fixed the problem.
I know this sounds *really odd*, but I thought I'd let you know.


Version: 1.7.x
Severity: minor
OS: Linux

Details

Reference
bz7305

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 9:27 PM
bzimport set Reference to bz7305.
bzimport added a subscriber: Unknown Object (MLST).

Fixed in r16504, using the === comparator in place of ==.