Page MenuHomePhabricator

Search button has no id
Closed, ResolvedPublic

Description

Author: lcarsdata

Description:
The search button has no id which makes it difficult to customize using user
css. All it needs is an id="something" adding and it will be fixed. The go
button already has one.


Version: 1.9.x
Severity: minor

Details

Reference
bz7745

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:24 PM
bzimport set Reference to bz7745.
bzimport added a subscriber: Unknown Object (MLST).

lcarsdata wrote:

BTW this is in the monobook skin.

lcarsdata wrote:

Adds id to search button in MonoBook.php

Here is the latest version of MonoBook.php but with an id added to the search
button, the id is "searchSearchButon" - I chose that because it uses the same
syntax as for the go button.

attachment MonoBook.php ignored as obsolete

Created attachment 2590
Patch in unified diff format

My version of this patch. Resubmitting because the earlier patch was not in
unified diff format (he still beat me, though!)

Attached:

Comment on attachment 2589
Adds id to search button in MonoBook.php

Obsoleting old attachment

ayg wrote:

New id's/classes should be prefixed with mw- to avoid conflicts with
user-specified stuff. Also, Cologne Blue is already using "mw-searchButton", so
I went with that. Fixed in r17289.