Page MenuHomePhabricator

add regression test support for parser functions
Closed, ResolvedPublic

Description

Author: ssanbeg

Description:
The regression test suite is really useful, and only needs a minor enhancement
to support parser functions.


Version: 1.9.x
Severity: normal
OS: Linux
Platform: PC

Details

Reference
bz7801

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:28 PM
bzimport set Reference to bz7801.
bzimport added a subscriber: Unknown Object (MLST).

ssanbeg wrote:

patch to support parser functions

This patch allows loading parser functions, i.e.

!! functionhooks
my-tag
!! endfunctionhooks

attachment pt-pf.patch ignored as obsolete

This produces a PHP warning when run and there's no !!functionhooks section:

Warning: Invalid argument supplied for foreach() in /opt/web/pages/trunk/maintenance/parserTests.inc
on line 281

Make sure you test with error_reporting set to E_ALL.

ssanbeg wrote:

update to supress warning

OK, it's fixed, and tested with the default file and one that included the
parser functions.

Attached:

Thanks! Applied on trunk in r17410