Page MenuHomePhabricator

RSS feed sets white background color and may be unreadable
Closed, ResolvedPublic

Description

Author: dodgy

Description:
If you're viewing the feed in a website that uses white text color, the text is
unreadable because it's white on white.

When specifying a background color, one should always set a text color, or
completely remove colors.

WRONG: style="background-color: white;" (background color specified without text
color)
WRONG: style="color: black;" (text color specified without background color)
RIGHT: style="background-color: white; color: black"
RIGHT: style=""

Solution 1: completely remove all colors from the RSS feed
Solution 2: If specifying a background color, a text color should also be specified


Version: unspecified
Severity: normal
URL: http://en.wikipedia.org/w/index.php?title=MediaWiki&action=history&feed=rss

Details

Reference
bz7989

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:27 PM
bzimport set Reference to bz7989.
bzimport added a subscriber: Unknown Object (MLST).

lcarsdata wrote:

Does anyone know where the code for this is stored. I have been through tons of
files and still can't find it. Please excuse me being a noob.

fyrenmoo wrote:

The CSS in skins/common/feed.css does set the color to black and background to
white, as far as I can tell.

Yes it does. Possibly the comment was about the generated content. The
'description' field includes table definitions that have background-color set to
white, but no color attribute.

E.g. (from the linked URL):

<description>&lt;p&gt;&lt;span class=&quot;autocomment&quot;&gt;Key features

-&lt;/span&gt; +extension&lt;/p&gt;

			&lt;table border='0' width='98%' cellpadding='0' cellspacing='4'

style=&quot;background-color: white;&quot;&gt;

			&lt;tr&gt;

...