Page MenuHomePhabricator

broken "previous" link in categories containing images
Closed, ResolvedPublic

Description

Author: tomasz.sienicki

Description:
Example: http://commons.wikimedia.org/w/index.php?title=Category:User-created_GFDL_images&until=Runway-operational.JPG

  1. open any category containing more than 200 images
  2. click (next 200)
  3. click (previous 200) → you'll get an empty page

100% reproducible on all wikimedia projects


Version: unspecified
Severity: normal

Details

Reference
bz10265

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 9:51 PM
bzimport set Reference to bz10265.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 10271 has been marked as a duplicate of this bug. ***

Jun 15 14:14:00 srv147 httpd[30857]: PHP Fatal error: Call to undefined method
Image::getNamespace() in
/usr/local/apache/common-local/php-1.5/includes/ImageGallery.php on line 212

Fixed in r23012. ImageGallery::add() had been updated to accept both Image and Title objects, but ImageGallery::insert() had not. The latter gets used in this paging mode for category galleries, so was storing the wrong object type in the internal array.