Page MenuHomePhabricator
Create Task
Maniphest T12463

wikilinks break in site notice of secure server
Closed, ResolvedPublic
Actions

Description

Author: Graf.Zahl

Description:
I access the English Wikisource through secure.wikimedia.org. Currently, there is the wikilink [[Wikisource:Reform month]] in the site notice. When the site notice is displayed at the top of the page, the resulting link is broken (leads to https://secure.wikimedia.org/wiki/Wikisource:Reform_month) and the server displays an error page. The link works fine from the non-secure server at http://en.wikisource.org.

Version: unspecified
Severity: normal
URL: https://secure.wikimedia.org/wikisource/en/wiki/MediaWiki:Sitenotice

Details

Reference
bz10463

Event Timeline

• bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:50 PM
• bzimport added projects: WMF-General-or-Unknown, Crosswiki.
• bzimport set Reference to bz10463.
• bzimport created this task.Jul 4 2007, 2:04 PM
• bzimport added a comment.Jul 4 2007, 3:19 PM

Graf.Zahl wrote:

Update: for some reason the link does not seem to break on the main page.

• brion added a comment.May 22 2008, 6:42 PM
  • Bug 14225 has been marked as a duplicate of this bug. ***
Danny_B added a comment.Jun 7 2008, 3:31 PM

*** Bug 14462 has been marked as a duplicate of this bug. ***

• bzimport added a comment.Sep 12 2008, 9:25 PM

bastique.bz wrote:

More and more people using the secure server these days. We adopted a workaround on otrswiki.wikimedia [{{fullurl:PAGENAME}} PAGENAME] , but it's still something that can and should be fixed :) Or else you'll get more and more duplicates of this bug ! :)

• brion added a comment.Sep 16 2008, 9:17 PM

Should be fixed by r40937... This appends $wgRenderHashAppend to the sitenotice cache keys (as is done for the parser cache keys) to allow the SSL cache to be maintained separately.

In quick testing it looks ok; commons on SSL shows SSL links in its sitenotice; commons in non-SSL shows non-SSL. Yay!

I am though getting 'false' returned from memcached for the SSL key ("commonswiki:sitenotice:https=1") rather than the array I'm expecting, which is a bit weird.

This may be due to a down or funky memcached. :P

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL