Author: mediawiki-bugreports

Description:
Actually this bug is against version 1.12alpha (r26409) as installed on de.wikinews.org but i could not choose that version.

I believe i have found a bug in the handling of the JavaScript mwCustomEditButtons variable. I have added this code to MediaWiki:Common.js:

function addCustomButton(imageFile, speedTip, tagOpen, tagClose, sampleText)
{
mwCustomEditButtons[mwCustomEditButtons.length] =
{"imageFile": imageFile,

"speedTip": speedTip,
"tagOpen": tagOpen,
"tagClose": tagClose,
"sampleText": sampleText};

}

I use this function to add custom buttons to the edit bar. Now MediaWiki seems to be intended to place the cursor between the output of "tagOpen" and "tagClose". When i add a button like this...

addCustomButton('http://upload.wikimedia.org/wikipedia/commons/b/bb/Button_ébauche.png','test',
"foo","bar","");

...it works without a flaw and places the cursor between 'foo' and 'bar'. When i however add a button like this...

addCustomButton('http://upload.wikimedia.org/wikipedia/commons/b/bb/Button_ébauche.png','test',
"foo","bar\nbaz\n","");

...it does not work correct, but places the cursor after the 'a' of the word 'bar'. What triggers the bug seems to be the newlines (\n) in the tagClose text. It looks like the correct position for the cursor is counted from the end of the text but the newlines are not considered in this, therefore placing the cursor two positions too far to the end of the text (because the tagClose text contains two newlines).

Version: 1.12.x
Severity: minor