Page MenuHomePhabricator

possible image thumbnailing restriction prevention
Closed, ResolvedPublic

Description

the allmighty patch

After checking the imagemagick documentation, I concluded that following patch could take care of the arbitrary 12.5Mpixel limit, and concentrate on limiting the used cache instead.


Version: unspecified
Severity: enhancement

Attached:

Details

Reference
bz12374

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 9:59 PM
bzimport set Reference to bz12374.
bzimport added a subscriber: Unknown Object (MLST).

Some of my notes from IRC; other than bringing the patch up to date a couple things to note:

[4:05pm] brion: the rule exception check looks wrong; it's only with ImageMagick that we can safely scale large JPEGs
[4:05pm] brion: if we tried it with GD we'd need to load the full image into memory, i believe
[4:06pm] brion: some sensible example values for the limits could be useful, as well as simply testing to confirm that it doesn't go beyond those limits with large PNG and TIFF sources
[4:06pm] brion: should collect some sample input files...

Marking as duplicate of bug 9497 since the patch tries to address the same issue.

  • This bug has been marked as a duplicate of bug 9497 ***