Page MenuHomePhabricator

Move PngFix code to IEFixes.js
Closed, ResolvedPublic

Description

Author: rememberthedot

Description:
Please move the PngFix code from http://en.wikipedia.org/wiki/MediaWiki:Common.js to IEFixes.js. The code has become highly stable and flexible, and can be disabled on any wiki by adding "window.PngFixDisabled = true" to Mediawiki:Common.js.

Moving this fix to the main IEFixes.js has two advantages:

  1. Decreased load time for English Wikipedia users who are not using IE
  2. The fix would be applied on all wikis, avoiding the need to manually copy it to each one's Common.js

Feel free to change "PngFix" to "pngFix" and "PngFixDisabled" to "pngFixDisabled" if this better matches your naming conventions. I doubt very many users (if any) actually set PngFixDisabled, so it wouldn't cause many problems.


Version: unspecified
Severity: enhancement

Details

Reference
bz12405

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:01 PM
bzimport set Reference to bz12405.
bzimport added a subscriber: Unknown Object (MLST).

The IE6 fix is now at :
http://en.wikipedia.org/wiki/MediaWiki:Common.js/IE60Fixes.js

It can probably replaces fixalpha() in IEFixes.js

This piece of code seems to fix the issue reported in bug 234, so I'm going to merge these two. Feel free to undo this change if the assessment was erroneous.

  • This bug has been marked as a duplicate of bug 234 ***