Page MenuHomePhabricator

improperly closed references tag should result in an obvious error
Closed, ResolvedPublic

Description

Author: random832

Description:
Right now, if someone closes a <ref> tag with <ref> instead of </ref>, a lot of content gets shoved down into the reference, but there's no boldface red text to say what has gone wrong. My suggestion: if <ref> is detected inside a <ref> tag, it is an error; an error message should show up at the location of the <ref> tag.


Version: unspecified
Severity: enhancement

Details

Reference
bz12757

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:02 PM
bzimport added a project: Cite.
bzimport set Reference to bz12757.
bzimport added a subscriber: Unknown Object (MLST).

Created attachment 4824
Proposed patch

attachment UnclosedRefTags.patch ignored as obsolete

Please review, it's an easy fix.

Looks straightforward; this is a good candidate for adding a parser test case to make sure it doesn't regress. (to citeParserTests.txt)

Created attachment 4997
Changes due to introduction of Cite_body.php, tests

Attached:

webboy wrote:

*** This bug has been marked as a duplicate of bug 6199 ***