Page MenuHomePhabricator

New parser breaks signatures inside gallery tags
Closed, DuplicatePublic

Description

Author: daniel

Description:
The new parser update breaks signatures inside gallery tags. This in turn breaks the work flow at [[:commons:COM:QIC]] (Quality image candidates). Plus it is unexpected behaviour.


Version: 1.12.x
Severity: major
URL: http://commons.wikimedia.org/wiki/Commons:Village_pump#sigs_in_galleries_not_working.3F

Details

Reference
bz13120

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 10:06 PM
bzimport added a project: MediaWiki-Parser.
bzimport set Reference to bz13120.
bzimport added a subscriber: Unknown Object (MLST).

Parser_OldPP.php:3757:

$text = $this->strip( $text, $stripState, true, array( 'gallery' ) );

What an awful special case hack. I'm wondering if there is some more elegant way to handle this. As a workaround, you could use {{#tag:gallery|... {{!}} .. }}. I'm wondering if that's a decent long-term solution as well.

daniel wrote:

No, I would not consider it a decent long-term solution. It just moves the hackishness to a different level, to the users. And this way a lot more people would have to deal with it. We cannot expect the users to learn a completely new syntax for doing something they already know how to do with <gallery> tags and the regular |-symbol.
QI is (was until the parser change hampered it) a successful and very active project to evaluate and tag large amounts of images according to a fixed quality standard. It's recipe for success is in part the simplicity of the process.
I wonder if a less hackish generic support for signatures in extension tags could be implemented. But for the time being I'd very much appreciate if the old functionality could be restored, even if it means (temporarily) using a special case hack.

Bryan.TongMinh wrote:

*** Bug 14066 has been marked as a duplicate of this bug. ***

(Note there used to be a special-cased hack for <gallery> which is no longer present.) Duping to general bug 2700.

  • This bug has been marked as a duplicate of bug 2700 ***