Page MenuHomePhabricator

An article with only hiddencats show an empy category box
Closed, ResolvedPublic

Description

A grey empty box (catlinks) is shown for articles with only have hidden categories.


Version: 1.13.x
Severity: enhancement
URL: http://en.wikipedia.org/wiki/Early_childhood_education

Details

Reference
bz13234

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:07 PM
bzimport set Reference to bz13234.
bzimport added a subscriber: Unknown Object (MLST).
  • Bug 13152 has been marked as a duplicate of this bug. ***

*** Bug 13254 has been marked as a duplicate of this bug. ***

  • Bug 13277 has been marked as a duplicate of this bug. ***
  • Bug 13278 has been marked as a duplicate of this bug. ***

ayg wrote:

(From bug 13278 comment #1)

The interface for Skin::getCategoryLinks() will have to be changed to return
the enclosing div too, or some other marker to indicate whether it should all
be hidden or not. Easy but not a one- or two-line fix.

herd wrote:

Note that divs id=catlinks and class=catlinks have now been merged into one for this fix.

Also note that the CSS on two skins, chick and modern, now have some duplicate and contrary definitions, for example in /skins/modern/main.css:

.catlinks {
border: solid 1px #bbbbbb;
background-color: #f0f0f0;
padding: 0.5em 0.5em 0.5em 0.5em;
margin: 0 0 0 0;
}
.catlinks {
margin: 0 0 0 0;
padding: 0 0 0 0;
}

The second block should probably just be removed. As should ".catlinks { margin: 0; padding: 0; }" from skins/chick/main.css

If a page contains only hidden categories, I'm no longer shown them despite having my preferences set to see them... of course I can work around this by adding .catlinks-allhidden { display:block } to my monobook.css, but it'd be better if the user preferences were taken into account up front.