Page MenuHomePhabricator

Cannot edit section
Closed, DeclinedPublic

Description

Author: k9disc

Description:
When trying to edit a section this error is immediately returned:

Invalid h node passed to PPNode_DOM::splitHeading

Backtrace:

#0 /home/pawsitiv/public_html/discdogopedia/includes/Parser.php(4605): PPNode_DOM->splitHeading()
#1 /home/pawsitiv/public_html/discdogopedia/includes/Parser.php(4675): Parser->extractSections('===Vaults===?[[...', '1', 'get', false)
#2 /home/pawsitiv/public_html/discdogopedia/includes/EditPage.php(193): Parser->getSection('===Vaults===?[[...', '1', false)
#3 /home/pawsitiv/public_html/discdogopedia/includes/EditPage.php(982): EditPage->getContent(false)
#4 /home/pawsitiv/public_html/discdogopedia/includes/EditPage.php(473): EditPage->initialiseForm()
#5 /home/pawsitiv/public_html/discdogopedia/includes/EditPage.php(323): EditPage->edit()
#6 /home/pawsitiv/public_html/discdogopedia/includes/Wiki.php(444): EditPage->submit()
#7 /home/pawsitiv/public_html/discdogopedia/includes/Wiki.php(48): MediaWiki->performAction(Object(OutputPage), Object(Article), Object(Title), Object(User), Object(WebRequest))
#8 /home/pawsitiv/public_html/discdogopedia/index.php(90): MediaWiki->initialize(Object(Title), Object(OutputPage), Object(User), Object(WebRequest))
#9 {main}


Version: 1.12.x
Severity: normal
URL: http://pawsitivevybe.com/discdogopedia

Details

Reference
bz13354

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:07 PM
bzimport set Reference to bz13354.
bzimport added a subscriber: Unknown Object (MLST).

Weird. I can't reproduce this on 1.12rc1 or 1.13svn. Could you attach the wikitext of the page you're trying to edit? I saw ===Vaults===?[[ in your backtrace, which would be an invalid header (although that should be handled more gracefully, of course).

k9disc wrote:

Well, now my edit links for the sections are gone. Talk about weird...

Here's the wiki text from one of the sections:

Moving Back Vault

[[Image:shock.jpg|thumbnail]]
A moving Back Vault takes place when the handler is in motion as the dog is executing the vault.

There has always been a little bit of handler motion in Back Vault execution, but in recent years this motion has become significant enough to create an entirely new kind of vault.

[[Gary Shockley]] and Kodiak were pioneers in this dynamic trick in the United States and it's one of the defining aspects of their game that led them to a stellar 2002 competition season.

The history of the development of the Moving Back Vault in Japan is unclear, but one thing that is not unclear is that the Japanese players ([[Yachi Harai]]) have taken the Moving Back Vault to an entirely different level and have given the entire Disc Dog world a new avenue for evolution and creativity.

Thanks,
Ron

(In reply to comment #2)

Well, now my edit links for the sections are gone.

Are you sure you're not viewing a diff or an old version of the page?

rene.raule wrote:

I had the same problem with MW 1.12.0rc1. Solution:

Change in Preprocessor_DOM.php , function splitHeading

if( !this->nodeName == 'h')

to

if( !this->getName() == 'h')

Rene

anon.hui wrote:

I got the same error in mw 1.14.0 (php 5.0.5).
But on another machine that use mw 1.14.0 on php 5.2.4 cannot reproduce this.

anon.hui wrote:

http://www.nabble.com/%22Invalid-h-node-passed-to-PPNode_DOM::splitHeading%22-error-on-1.12-td16331196.html
<blockquote>
Try using the alternate preprocessor code; add this to your
LocalSettings.php:

$wgParserConf['preprocessorClass'] = 'Preprocessor_Hash';
</blockquote>

From reading the linked thread in comment #6, it seems to have been a combination of using Preprocessor_DOM and old 5.0.x PHP.

Closing as WFM. Feel free to reopen if you can replicate on a more recent version of Mediawiki and PHP (note we only support PHP 5.1 and higher--5.2 or 5.3 is recommended).