| Huji | |
| Mar 21 2008, 8:49 AM |
| F4614: revision-prob.png | |
| Nov 21 2014, 10:01 PM |
When two lines only differ in white spaces, this difference is not hilighted good enough. One would expect the white space(s) to be rendered with a (say) red background on the side where it exists (or, maybe, on the side it is omitted).
Version: unspecified
Severity: enhancement
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T72163 Edit conflicts (tracking) | |||
| Open | Feature | None | T15466 Design of diffs should be improved to indicate white space changes better | ||
| Declined | None | T6012 Add flexible magic character conversion to the user interface |
Yeah it doesn't look so nice with long changes inside one line, because it adds the border unlike for totally new or removed lines. Have to find suitable compromise between highlighting short whitespace changes and not overhighlighting long changes.
ayg wrote:
Maybe a different background color would be more attractive than a dotted border?
sumanah wrote:
green highlighted line on right should show added spaces at end, does not
Not sure whether http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28proposals%29&curid=3706897&diff=206582971&oldid=206580490 still shows the problem Aaron was pointing to. However, https://en.wikipedia.org/w/index.php?title=User%3ASumanah&action=historysubmit&diff=454459831&oldid=454452518 does (I believe) demonstrate the problem; screenshot attached.
Attached:
sumanah wrote:
Still an issue in 1.18.
Added "design" keyword - would appreciate some design thinking on how to, as Niklas summarizes in comment 5, "find suitable compromise between highlighting short whitespace changes and not overhighlighting long changes."
Moving under wikidiff2 per bug 13462 comment 7, although Nikerabbit says «dwdiff can use delimeters, that's not quite character level diff, [...] the algorithms are probably very different».
I suppose that this blocks bug 745, the tracker for RTL bugs, because it also doesn't clearly display changes in characters like RLM/LRM. Whoever resolves this should also consider showing emphasizing these characters somehow.
I don't know what the merged task talked about, but this bug is about *identification* of whitespace changes, not about their display. Display was already fixed, see https://www.mediawiki.org/wiki/MediaWiki_1.20#Diff