Page MenuHomePhabricator
Create Task
Maniphest T15759

memcached predefined hashes
Closed, ResolvedPublic
Actions

Description

Author: zac.bristow

Description:
(patched against r33276)

Some of the methods of the memcached class do not take into account the possibility of predefined hashes for keys [array(hash, key)]. The get_multi method already handles these hashes correctly, and this patch only allows the other methods to do the same. This does not alter existing behavior for simple string keys.

Version: unspecified
Severity: minor

Attached:

memcached-keys.patch576 BDownload

Details

Reference
bz13759

Event Timeline

• bzimport raised the priority of this task from to Low.Nov 21 2014, 10:07 PM
• bzimport added a project: MediaWiki-General.
• bzimport set Reference to bz13759.
• bzimport added a subscriber: Unknown Object (MLST).
• bzimport created this task.Apr 16 2008, 9:50 AM
• bzimport added a comment.Apr 16 2008, 9:52 AM

zac.bristow wrote:

fixed severity - not an enhancement

siebrand added a comment.Aug 18 2008, 8:51 PM

Keywords: need-review, easy.

Will ask Brion to take a quick look at this; patch seems pretty simple.

• brion added a comment.Aug 18 2008, 9:00 PM

Ugh, this is some scary code. :D

Documentation comments all indicate that $key parameters are to be strings. If arrays are also a possibility, please update the documentation in the class to indicate the proper way to make calls.

• bzimport added a comment.Feb 6 2010, 10:19 AM

karun.84 wrote:

Changed from easy.

Reedy added a comment.Nov 19 2011, 8:01 PM

r103705

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL