Page MenuHomePhabricator

add video/ogg and application/annodex to mimetypes
Closed, InvalidPublic

Description

Author: jgerber

Description:
right now cortado only check for application/ogg and fails for ogg/video or application/annodex, it should also try to decode those.
attached a patch to check for those mime-types too.


Version: unspecified
Severity: enhancement

Details

Reference
bz13900

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:08 PM
bzimport set Reference to bz13900.
bzimport added a subscriber: Unknown Object (MLST).

Attachment doesn't seem to have made it.

jgerber wrote:

the patch

Attached:

If we're to believe http://wiki.xiph.org/index.php/MIME_Types_and_File_Extensions we should probably toss in audio/ogg as well.

Comments in Cortado source seem to indicate that annodex streams aren't really supported properly as well, so perhaps we should *not* add those types?

I'll make myself a bit more clear: the MIME type should always come from OggDemux.getMime(), and is always application/ogg. It doesn't come from the webserver. If OggDemux.typeFind() is not recognising the header, then maybe it will then try to use the content type from the webserver, and give you a confusing error about type mismatch. Is this the problem? If so, the bug is the error handling, not the MIME type list. If the signature is invalid, it should tell you so, and refuse to play the file.

jgerber wrote:

indeed, i got an error message video/ogg not supported than changed that in the source and it worked,
removing it again now it also works so the error must have been something else.